Chromium Code Reviews
Help | Chromium Project | Sign in
(267)

Issue 11088078: Android backend: allow targets to have unmangled names. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Torne
Modified:
1 year, 6 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Android backend: allow targets to have unmangled names.

The Android backend mangles gyp target names because the Android build
system requires that they be globally unique. This is fine for most targets,
but for the final build products that are being used by other Android
components it's annoying to refer to long mangled names. Add a
generator-specific flag to denote that a target should have an unmangled
name, which can be set on the targets that are important after verifying
that no existing module in Android has the same name.
Committed: https://code.google.com/p/gyp/source/detail?r=1520

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Lint Patch
M pylib/gyp/generator/android.py View 1 3 chunks +18 lines, -4 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 9
Torne
Nico, would you mind looking at this, or would someone else be better? steveblock is ...
1 year, 6 months ago #1
Nico
What target types do you need this for? If only static libraries: we recently added ...
1 year, 6 months ago #2
Torne
On 2012/10/15 19:32:05, Nico wrote: > What target types do you need this for? If ...
1 year, 6 months ago #3
Nico
https://codereview.chromium.org/11088078/diff/1/pylib/gyp/generator/android.py File pylib/gyp/generator/android.py (right): https://codereview.chromium.org/11088078/diff/1/pylib/gyp/generator/android.py#newcode589 pylib/gyp/generator/android.py:589: if spec.get('android_unmangled_name'): This is true for targets that say ...
1 year, 6 months ago #4
Torne
https://codereview.chromium.org/11088078/diff/1/pylib/gyp/generator/android.py File pylib/gyp/generator/android.py (right): https://codereview.chromium.org/11088078/diff/1/pylib/gyp/generator/android.py#newcode589 pylib/gyp/generator/android.py:589: if spec.get('android_unmangled_name'): On 2012/10/15 23:35:13, Nico wrote: > This ...
1 year, 6 months ago #5
Nico
lgtm Since it sounds like this will be used in production soon / is already ...
1 year, 6 months ago #6
Torne
On 2012/10/16 21:07:44, Nico wrote: > lgtm > > Since it sounds like this will ...
1 year, 6 months ago #7
Nico
On 2012/10/17 10:38:34, Torne wrote: > On 2012/10/16 21:07:44, Nico wrote: > > lgtm > ...
1 year, 6 months ago #8
Torne
1 year, 6 months ago #9
On 2012/10/17 17:02:28, Nico wrote:
> On 2012/10/17 10:38:34, Torne wrote:
> > On 2012/10/16 21:07:44, Nico wrote:
> > > lgtm
> > > 
> > > Since it sounds like this will be used in production soon / is already
used
> > > there: Any thoughts on testing? There should probably a bot with an
android
> > > toolchain installed?
> > 
> > This is on my todo list; once I have our build going for my team I am going
to
> > look at getting gyp testing done properly next.
> 
> Sounds good. I forget, is there a tracking bug for this already? If not, can
you
> file one?

http://code.google.com/p/gyp/issues/detail?id=275

> > Sorry this hasn't happened
> > already; we have had crazy deadlines :p
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6