Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issue 11088058: Merge 130691 - Mac Chromium: Ignore system numpad modifier (Closed)

Created:
8 years, 2 months ago by karen
Modified:
8 years, 2 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 130691 - Mac Chromium: Ignore system numpad modifier https://bugs.webkit.org/show_bug.cgi?id=97161 Patch by Sailesh Agrawal <sail@chromium.org>; on 2012-10-08 Reviewed by Tony Chang. On Mac, arrow key events have numpad modifier set. This is inconsistent with other platforms. My fix is to only rely on keycode to decide when to set the numpad modifier. This code is not exersided by layout tests so I added a new unit test for this. * WebKit.gypi: * WebKitUnitTests.gyp: * src/mac/WebInputEventFactory.mm: (WebKit::isKeypadEvent): Removed check for numpad modifier. * tests/WebInputEventFactoryTestMac.mm: Added. (TEST): Added new test for WebInputEventFactory::keyboardEvent(). TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
Source/WebKit/chromium/WebKit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
Source/WebKit/chromium/WebKitUnitTests.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
Source/WebKit/chromium/src/mac/WebInputEventFactory.mm View 1 chunk +0 lines, -3 lines 0 comments Download
Source/WebKit/chromium/tests/WebInputEventFactoryTestMac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
karen
8 years, 2 months ago (2012-10-10 20:20:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698