Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: ui/views/controls/menu/menu_config_views.cc

Issue 11088037: Revert 160886 - Added MenuConfig setter to MenuItemView, updated rest of the code to use set MenuCo… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/menu/menu_config.cc ('k') | ui/views/controls/menu/menu_config_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_config_views.cc
===================================================================
--- ui/views/controls/menu/menu_config_views.cc (revision 160892)
+++ ui/views/controls/menu/menu_config_views.cc (working copy)
@@ -13,32 +13,36 @@
namespace views {
-void MenuConfig::Init() {
- text_color = ui::NativeTheme::instance()->GetSystemColor(
+// static
+MenuConfig* MenuConfig::Create() {
+ MenuConfig* config = new MenuConfig();
+ config->text_color = ui::NativeTheme::instance()->GetSystemColor(
ui::NativeTheme::kColorId_EnabledMenuItemForegroundColor);
- submenu_horizontal_margin_size = 0;
- submenu_vertical_margin_size = 0;
- submenu_horizontal_inset = 1;
+ config->submenu_horizontal_margin_size = 0;
+ config->submenu_vertical_margin_size = 0;
+ config->submenu_horizontal_inset = 1;
ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
- arrow_to_edge_padding = 20;
- icon_to_label_padding = 4;
- arrow_width = rb.GetImageNamed(IDR_MENU_ARROW).ToImageSkia()->width();
+ config->arrow_to_edge_padding = 20;
+ config->icon_to_label_padding = 4;
+ config->arrow_width = rb.GetImageNamed(IDR_MENU_ARROW).ToImageSkia()->width();
const gfx::ImageSkia* check = rb.GetImageNamed(IDR_MENU_CHECK).ToImageSkia();
// Add 4 to force some padding between check and label.
- check_width = check->width() + 4;
- check_height = check->height();
- item_left_margin = 4;
- item_min_height = 29;
- separator_height = 15;
- separator_spacing_height = 7;
- separator_lower_height = 8;
- separator_upper_height = 8;
- font = rb.GetFont(ResourceBundle::BaseFont);
- label_to_arrow_padding = 20;
- label_to_accelerator_padding = 20;
- always_use_icon_to_label_padding = true;
- align_arrow_and_shortcut = true;
- offset_context_menus = true;
+ config->check_width = check->width() + 4;
+ config->check_height = check->height();
+ config->item_left_margin = 4;
+ config->item_min_height = 29;
+ config->separator_height = 15;
+ config->separator_spacing_height = 7;
+ config->separator_lower_height = 8;
+ config->separator_upper_height = 8;
+ config->font = rb.GetFont(ResourceBundle::BaseFont);
+ config->label_to_arrow_padding = 20;
+ config->label_to_accelerator_padding = 20;
+ config->always_use_icon_to_label_padding = true;
+ config->align_arrow_and_shortcut = true;
+ config->offset_context_menus = true;
+
+ return config;
}
} // namespace views
« no previous file with comments | « ui/views/controls/menu/menu_config.cc ('k') | ui/views/controls/menu/menu_config_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698