Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1108803002: Re-enable local video test with better logging and higher tolerance. (Closed)

Created:
5 years, 8 months ago by phoglund_chromium
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable local video test with better logging and higher tolerance. The test appears to get stuck on waiting for black frames. This patch adds some logging so we perhaps can learn more where in the image we find the nonblack pixels. Also trying to increase tolerance for rounding errors somewhat to see if that helps. BUG=477498 Committed: https://crrev.com/839a0eb5f8aeff1de8263eff28e55cb8b5fe7396 Cr-Commit-Position: refs/heads/master@{#329616}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Putting back TSAN disable #

Total comments: 2

Patch Set 4 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M content/test/data/media/webrtc_test_utilities.js View 1 2 3 3 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (6 generated)
phoglund_chromium
5 years, 8 months ago (2015-04-28 08:38:40 UTC) #2
phoglund_chromium
friendly ping :)
5 years, 7 months ago (2015-04-29 11:20:28 UTC) #3
phoglund_chromium
friendly ping :)
5 years, 7 months ago (2015-05-04 11:55:11 UTC) #4
phoglund_chromium
friendly ping
5 years, 7 months ago (2015-05-06 07:08:31 UTC) #6
phoglund_chromium
increasingly unfriendly ping (just kidding :)
5 years, 7 months ago (2015-05-11 15:43:56 UTC) #7
phoglund_chromium
5 years, 7 months ago (2015-05-12 12:42:20 UTC) #10
kjellander_chromium
Were you pinging the CL with no reviewer earlier? This is the first e-mail I've ...
5 years, 7 months ago (2015-05-12 13:35:46 UTC) #11
phoglund_chromium
No, I had tommi as reviewer but didn't get a response for two weeks so ...
5 years, 7 months ago (2015-05-12 14:22:27 UTC) #12
phoglund_chromium
PTAL https://codereview.chromium.org/1108803002/diff/40001/content/test/data/media/webrtc_test_utilities.js File content/test/data/media/webrtc_test_utilities.js (right): https://codereview.chromium.org/1108803002/diff/40001/content/test/data/media/webrtc_test_utilities.js#newcode209 content/test/data/media/webrtc_test_utilities.js:209: // Should be == 0, but account for ...
5 years, 7 months ago (2015-05-13 08:47:35 UTC) #13
kjellander_chromium
lgtm
5 years, 7 months ago (2015-05-13 08:58:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108803002/60001
5 years, 7 months ago (2015-05-13 09:56:57 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-13 11:34:23 UTC) #17
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/839a0eb5f8aeff1de8263eff28e55cb8b5fe7396 Cr-Commit-Position: refs/heads/master@{#329616}
5 years, 7 months ago (2015-05-13 11:35:11 UTC) #18
tommi (sloooow) - chröme
oops... sorry, I didn't see this until now :( made a change in my filters ...
5 years, 7 months ago (2015-05-13 21:39:05 UTC) #20
phoglund_chromium
On 2015/05/13 21:39:05, tommi wrote: > oops... sorry, I didn't see this until now :( ...
5 years, 7 months ago (2015-05-15 11:10:21 UTC) #21
jam
5 years, 7 months ago (2015-05-15 16:07:02 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1142643004/ by jam@chromium.org.

The reason for reverting is: still flaky, see
http://chromium-try-flakes.appspot.com/search?q=WebRtcBrowserTest.CanSetupVid...
and
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_....

Powered by Google App Engine
This is Rietveld 408576698