Added a simple dead code removal phase.

Added a simple dead code removal phase.

We iteratively remove all dead Hydrogen instruction until we reach a fixed point. We consider an instruction dead if it is unused, has no observable side effects and is deletable. The last part of the condition is currently not very nice: We basically have to whitelist "safe" instructions, because we are missing more detailed dependencies and/or more detailed tracking of side effects.

We disable dead code elimination for now in our test runners, because we have tons of poorly written tests which wouldn't test anymore what they are supposed to test with this phase enabled. To get test coverage for dead code elimination itself, we should enable it on a few build bots. This is not really a perfect state, but the best we can do for now.

This patch includes a few const-correctness fixes, most of them were necessary for this CL.

Committed: https://code.google.com/p/v8/source/detail?r=12697

[Jakob Kummerow, 2012-10-10 15:24:18]

As discussed, we should adapt the test driver in this CL too.

IMHO, less verbose output of --trace-dead-code-elimination (just id() and
Mnemonic() of the HValue being removed) would be completely sufficient; but you
can keep what you have if you prefer.

https://codereview.chromium.org/11088027/diff/2001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/11088027/diff/2001/src/hydrogen-instructions....
src/hydrogen-instructions.h:4435: return elements_kind_ !=
EXTERNAL_UNSIGNED_INT_ELEMENTS;
As discussed offline, this instruction is always deletable.

[Sven Panne, 2012-10-11 06:48:32]

Landing...

https://codereview.chromium.org/11088027/diff/2001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/11088027/diff/2001/src/hydrogen-instructions....
src/hydrogen-instructions.h:4435: return elements_kind_ !=
EXTERNAL_UNSIGNED_INT_ELEMENTS;
On 2012/10/10 15:24:18, Jakob wrote:
> As discussed offline, this instruction is always deletable.

Done.

[Jakob Kummerow, 2012-10-11 10:49:13]

lgtm