Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in

Issue 11088026: Make sure that the context argument of HAdd is never NULL. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
5 years ago by Sven Panne
5 years ago
Jakob Kummerow


Make sure that the context argument of HAdd is never NULL. Although this doesn't hurt currently, it hurts any future compiler pass relying on the invariant that no operand is NULL. Committed:

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/ View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +3 lines, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).


Total messages: 2 (0 generated)
Jakob Kummerow
LGTM with RFC. File src/ (right): src/ HValue* context = HBinaryOperation::cast(check->index())->context(); I'd appreciate ...
5 years ago (2012-10-09 13:49:22 UTC) #1
Sven Panne
5 years ago (2012-10-09 13:53:11 UTC) #2
Comment added, landing...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa