Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 11088026: Make sure that the context argument of HAdd is never NULL. (Closed)

Created:
5 years, 1 month ago by Sven Panne
Modified:
5 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make sure that the context argument of HAdd is never NULL. Although this doesn't hurt currently, it hurts any future compiler pass relying on the invariant that no operand is NULL. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12681

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/hydrogen.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +3 lines, -0 lines 0 comments Download
Trybot results:

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
LGTM with RFC. https://codereview.chromium.org/11088026/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/11088026/diff/1/src/hydrogen.cc#newcode3570 src/hydrogen.cc:3570: HValue* context = HBinaryOperation::cast(check->index())->context(); I'd appreciate ...
5 years, 1 month ago (2012-10-09 13:49:22 UTC) #1
Sven Panne
5 years, 1 month ago (2012-10-09 13:53:11 UTC) #2
Comment added, landing...

Powered by Google App Engine
This is Rietveld efc10ee0f