Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 11088020: Merge 130717 - HTMLSelectElement::typeAheadFind depends on implementation dependent behavior (Closed)

Created:
8 years, 2 months ago by yosin_UTC9
Modified:
8 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 130717 - HTMLSelectElement::typeAheadFind depends on implementation dependent behavior https://bugs.webkit.org/show_bug.cgi?id=98710 Reviewed by Kent Tamura. Source/WebCore: This patch gets rid of C/C++ implementation dependent behavior from HTMLSelectElement::typeAheadFind() which does modulo operation with a negative operand. HTMLSelectElement::typeAheadFind() contains expression with modulo operator and dividend can be -1 when the "select" element without "option" element but "optgroup" element. Test: fast/forms/select/select-typeahead-crash.html * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::typeAheadFind): Changed to do modulo operation with both operands are non-negative. LayoutTests: This patch adds a test for checking HTMLSelectElement::typeAheadFind doesn't crash. * fast/forms/select/select-typeahead-crash-expected.txt: Added. * fast/forms/select/select-typeahead-crash.html: Added. TBR=yosin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A + LayoutTests/fast/forms/select/select-typeahead-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/select/select-typeahead-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/html/HTMLSelectElement.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
yosin_UTC9
8 years, 2 months ago (2012-10-09 05:59:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698