Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 11088016: Run tests on buildbot. (Closed)

Created:
8 years, 5 months ago by Sam Clegg
Modified:
8 years, 5 months ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Run tests on buildbot. Also fix a couple of failing tests. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1432

Patch Set 1 #

Patch Set 2 : #

Total comments: 14

Patch Set 3 : fixes based on review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -33 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/install.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/install.py View 1 2 5 chunks +19 lines, -16 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs View 1 chunk +1 line, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/PropertyManagerTest.cs View 2 chunks +2 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/build.bat View 1 1 chunk +4 lines, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/buildbot_run.py View 1 2 5 chunks +51 lines, -10 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/developer_deploy.bat View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
8 years, 5 months ago (2012-10-08 23:59:43 UTC) #1
Sam Clegg
On 2012/10/08 23:59:43, Sam Clegg wrote: All tests currently pass against pepper_23 and pepper_canary
8 years, 5 months ago (2012-10-09 00:00:12 UTC) #2
binji
lgtm, w/ nits... probably want to clean this script up when you get it all ...
8 years, 5 months ago (2012-10-09 01:05:11 UTC) #3
Sam Clegg
8 years, 5 months ago (2012-10-09 17:04:33 UTC) #4
http://codereview.chromium.org/11088016/diff/1001/visual_studio/NativeClientV...
File visual_studio/NativeClientVSAddIn/buildbot_run.py (right):

http://codereview.chromium.org/11088016/diff/1001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/buildbot_run.py:16: from os.path import join
On 2012/10/09 01:05:11, binji wrote:
> any reason for this? calling it "join" makes it seem like it joins strings not
> path components.

This is a pattern that I've followed over the years
when writing command line python tools.  If find that 
command line code is often littered with "os.path.join"
and the code can be much more readable with just "join",
but you are right its not the best name.

http://codereview.chromium.org/11088016/diff/1001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/buildbot_run.py:30: if sys.platform ==
'cygwin':
On 2012/10/09 01:05:11, binji wrote:
> what about when the cmd is a list?

You are right it could be nicer.  I'm making the assumption
that bat files in the current working directory are called
as strings and the other commands in this file are list.

I cleaned this up.

http://codereview.chromium.org/11088016/diff/1001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/buildbot_run.py:52: sdk_root = join('..',
'..', 'out', 'sdk')
On 2012/10/09 01:05:11, binji wrote:
> make this path a constant.

Done.

http://codereview.chromium.org/11088016/diff/1001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/buildbot_run.py:58: url =
"http://storage.googleapis.com/nativeclient-mirror/nacl/nacl_sdk/nacl_sdk.zip"
On 2012/10/09 01:05:11, binji wrote:
> Use GSURL above (and add a new path to this file)

Done.

http://codereview.chromium.org/11088016/diff/1001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/buildbot_run.py:63: print zfile
On 2012/10/09 01:05:11, binji wrote:
> does this print anything useful?

Done.

http://codereview.chromium.org/11088016/diff/1001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/buildbot_run.py:75:
os.environ['NACL_SDK_ROOT'] = join(sdk_root, 'pepper_23')
On 2012/10/09 01:05:11, binji wrote:
> Probably nicer to set the environment in RunCommand, rather than change this
> scripts environment.

Done.

http://codereview.chromium.org/11088016/diff/1001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/buildbot_run.py:131: #StepBuild()
On 2012/10/09 01:05:11, binji wrote:
> debugging?

Done.

Powered by Google App Engine
This is Rietveld 408576698