Refactor SsaBuilder.visitSuperSend.

tests/compiler/dart2js/semantic_visitor_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.semantics_visitor_test;
 
 import 'dart:async';
 import 'package:async_helper/async_helper.dart';
 import 'package:expect/expect.dart';
 import 'package:compiler/src/constants/expressions.dart';
@@ skipping 796 matching lines @@
     const Test.clazz(
         '''
         class B {
           var o;
         }
         class C extends B {
           m() { super.o(null, 42); }
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_FIELD_INVOKE,
-                    element: 'field(B#o)',
-                    arguments: '(null,42)')),
+                element: 'field(B#o)',
+                arguments: '(null,42)')),
+    const Test.clazz(
+            '''
+        class B {
+        }
+        class C extends B {
+          m() => super.o;
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SUPER_GET)),
   ],
   'Super properties': const [
     // Super properties
     const Test.clazz(
         '''
         class B {
           get o => null;
         }
         class C extends B {
           m() => super.o;
@@ skipping 44 matching lines @@
         class B {
           o(a, b) {}
         }
         class C extends B {
           m() { super.o(null, 42); }
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_METHOD_INVOKE,
                     element: 'function(B#o)',
                     arguments: '(null,42)')),
+    const Test.clazz(
+        '''
+        class B {
+          o(a, b) {}
+        }
+        class C extends B {
+          m() { super.o(null); }
+        }
+        ''',
+        const Visit(VisitKind.VISIT_SUPER_METHOD_INCOMPATIBLE_INVOKE,
+                    element: 'function(B#o)',
+                    arguments: '(null)')),
+    const Test.clazz(
+            '''
+            class B {
+            }
+            class C extends B {
+              m() => super.o(null, 42);
+            }
+            ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SUPER_INVOKE,
+                    arguments: '(null,42)')),
   ],
   'Expression invoke': const [
     // Expression invoke
     const Test('m() => (a, b){}(null, 42);',
         const Visit(VisitKind.VISIT_EXPRESSION_INVOKE,
                     receiver: '(a,b){}',
                     arguments: '(null,42)')),
   ],
   'Class type literals': const [
     // Class type literals
@@ skipping 219 matching lines @@
           operator +(_) => null;
         }
         class C extends B {
           m() => super + 42;
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_BINARY,
                     element: 'function(B#+)',
                     operator: '+',
                     right: '42')),
+    const Test.clazz(
+        '''
+        class B {}
+        class C extends B {
+          m() => super + 42;
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SUPER_BINARY,
+                    operator: '+',
+                    right: '42')),
   ],
   'Index': const [
     // Index
     const Test(
         '''
         m() => 2[3];
         ''',
         const Visit(VisitKind.VISIT_INDEX,
                     receiver: '2', index: '3')),
     const Test(
@@ skipping 16 matching lines @@
         class C extends B {
           m() => super[42];
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_INDEX,
                     element: 'function(B#[])',
                     index: '42')),
     const Test.clazz(
         '''
         class B {
+        }
+        class C extends B {
+          m() => super[42];
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SUPER_INDEX,
+                    index: '42')),
+    const Test.clazz(
+        '''
+        class B {
           operator [](_) => null;
           operator []=(a, b) {}
         }
         class C extends B {
           m() => ++super[42];
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_INDEX_PREFIX,
                     getter: 'function(B#[])',
                     setter: 'function(B#[]=)',
@@ skipping 79 matching lines @@
         }
         class C extends B {
           m() => -super;
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_UNARY,
                     element: 'function(B#unary-)', operator: '-')),
     const Test.clazz(
         '''
         class B {
+        }
+        class C extends B {
+          m() => -super;
+        }
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_SUPER_UNARY,
+                    operator: '-')),
+    const Test.clazz(
+        '''
+        class B {
           operator ~() => null;
         }
         class C extends B {
           m() => ~super;
         }
         ''',
         const Visit(VisitKind.VISIT_SUPER_UNARY,
                     element: 'function(B#~)', operator: '~')),
     const Test(
         '''
@@ skipping 2345 matching lines @@
   }
 
   @override
   visitSuperBinary(
       Send node,
       FunctionElement function,
       BinaryOperator operator,
       Node argument,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_BINARY,
-            element: function, operator: operator, right: argument));
+        element: function, operator: operator, right: argument));
     apply(argument, arg);
   }
 
   @override
+  visitUnresolvedSuperBinary(
+      Send node,
+      Element element,
+      BinaryOperator operator,
+      Node argument,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_UNRESOLVED_SUPER_BINARY,
+        operator: operator, right: argument));
+    apply(argument, arg);
+  }
+
+
+  @override
   visitSuperIndex(
       Send node,
       FunctionElement function,
       Node index,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_INDEX,
             element: function, index: index));
     apply(index, arg);
   }
 
   @override
+  visitUnresolvedSuperIndex(
+      Send node,
+      Element element,
+      Node index,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_UNRESOLVED_SUPER_INDEX,
+        index: index));
+    apply(index, arg);
+  }
+
+  @override
   visitSuperNotEquals(
       Send node,
       FunctionElement function,
       Node argument,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_NOT_EQUALS,
             element: function, right: argument));
     apply(argument, arg);
   }
 
@@ skipping 213 matching lines @@
 
   @override
   visitSuperFieldGet(
       Send node,
       FieldElement field,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_FIELD_GET, element: field));
   }
 
   @override
+  visitUnresolvedSuperGet(
+      Send node,
+      Element element,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_UNRESOLVED_SUPER_GET));
+  }
+
+  @override
   visitSuperFieldInvoke(
       Send node,
       FieldElement field,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_FIELD_INVOKE,
         element: field, arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
+  visitUnresolvedSuperInvoke(
+      Send node,
+      Element element,
+      NodeList arguments,
+      Selector selector,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_UNRESOLVED_SUPER_INVOKE,
+        arguments: arguments));
+    apply(arguments, arg);
+  }
+
+  @override
   visitSuperFieldSet(
       SendSet node,
       FieldElement field,
       Node rhs,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_FIELD_SET,
         element: field, rhs: rhs));
     apply(rhs, arg);
   }
 
@@ skipping 11 matching lines @@
       MethodElement method,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_METHOD_INVOKE,
         element: method, arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
+  visitSuperMethodIncompatibleInvoke(
+      Send node,
+      MethodElement method,
+      NodeList arguments,
+      CallStructure callStructure,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_SUPER_METHOD_INCOMPATIBLE_INVOKE,
+        element: method, arguments: arguments));
+    apply(arguments, arg);
+  }
+
+  @override
   visitSuperGetterGet(
       Send node,
       FunctionElement getter,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_GETTER_GET, element: getter));
   }
 
   @override
   visitSuperGetterInvoke(
       Send node,
@@ skipping 21 matching lines @@
   visitSuperUnary(
       Send node,
       UnaryOperator operator,
       FunctionElement function,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_UNARY,
         element: function, operator: operator));
   }
 
   @override
+  visitUnresolvedSuperUnary(
+      Send node,
+      UnaryOperator operator,
+      Element element,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_UNRESOLVED_SUPER_UNARY,
+        operator: operator));
+  }
+
+  @override
   visitEquals(
       Send node,
       Node left,
       Node right,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_EQUALS, left: left, right: right));
     apply(left, arg);
     apply(right, arg);
   }
 
@@ skipping 1031 matching lines @@
   @override
   errorUndefinedUnaryExpression(
       Send node,
       Operator operator,
       Node expression,
       arg) {
     // TODO: implement errorUndefinedUnaryExpression
   }
 
   @override
-  errorUnresolvedSuperBinary(
-      Send node,
-      ErroneousElement element,
-      BinaryOperator operator,
-      Node argument,
-      arg) {
-    // TODO: implement errorUnresolvedSuperBinary
-  }
-
-  @override
   errorUnresolvedSuperCompoundIndexSet(
       Send node,
       ErroneousElement element,
       Node index,
       AssignmentOperator operator,
       Node rhs,
       arg) {
     // TODO: implement errorUnresolvedSuperCompoundIndexSet
   }
 
   @override
   errorUnresolvedSuperIndexSet(
       Send node,
       ErroneousElement element,
       Node index,
       Node rhs,
       arg) {
     // TODO: implement errorUnresolvedSuperIndexSet
   }
 
   @override
-  errorUnresolvedSuperUnary(
-      Send node,
-      UnaryOperator operator,
-      ErroneousElement element,
-      arg) {
-    // TODO: implement errorUnresolvedSuperUnary
-  }
-
-  @override
-  errorUnresolvedSuperIndex(
-      Send node,
-      Element element,
-      Node index,
-      arg) {
-    // TODO: implement errorUnresolvedSuperIndex
-  }
-
-  @override
   errorUnresolvedSuperIndexPostfix(
       Send node,
       Element function,
       Node index,
       IncDecOperator operator,
       arg) {
     // TODO: implement errorUnresolvedSuperIndexPostfix
   }
 
   @override
@@ skipping 928 matching lines @@
   VISIT_SUPER_FIELD_SETTER_COMPOUND,
   VISIT_SUPER_GETTER_SETTER_PREFIX,
   VISIT_SUPER_GETTER_FIELD_PREFIX,
   VISIT_SUPER_FIELD_SETTER_PREFIX,
   VISIT_SUPER_GETTER_SETTER_POSTFIX,
   VISIT_SUPER_GETTER_FIELD_POSTFIX,
   VISIT_SUPER_FIELD_SETTER_POSTFIX,
 
   VISIT_SUPER_METHOD_GET,
   VISIT_SUPER_METHOD_INVOKE,
+  VISIT_SUPER_METHOD_INCOMPATIBLE_INVOKE,
+
+  VISIT_UNRESOLVED_SUPER_GET,
+  VISIT_UNRESOLVED_SUPER_INVOKE,
 
   VISIT_BINARY,
   VISIT_INDEX,
   VISIT_EQUALS,
   VISIT_NOT_EQUALS,
   VISIT_INDEX_PREFIX,
   VISIT_INDEX_POSTFIX,
 
   VISIT_SUPER_BINARY,
+  VISIT_UNRESOLVED_SUPER_BINARY,
   VISIT_SUPER_INDEX,
+  VISIT_UNRESOLVED_SUPER_INDEX,
   VISIT_SUPER_EQUALS,
   VISIT_SUPER_NOT_EQUALS,
   VISIT_SUPER_INDEX_PREFIX,
   VISIT_SUPER_INDEX_POSTFIX,
 
   VISIT_UNARY,
   VISIT_SUPER_UNARY,
+  VISIT_UNRESOLVED_SUPER_UNARY,
   VISIT_NOT,
 
   VISIT_EXPRESSION_INVOKE,
 
   VISIT_CLASS_TYPE_LITERAL_GET,
   VISIT_CLASS_TYPE_LITERAL_SET,
   VISIT_CLASS_TYPE_LITERAL_INVOKE,
   VISIT_CLASS_TYPE_LITERAL_BINARY,
   ERROR_CLASS_TYPE_LITERAL_COMPOUND,
   ERROR_CLASS_TYPE_LITERAL_PREFIX,
@@ skipping 67 matching lines @@
   VISIT_OPTIONAL_PARAMETER_DECL,
   VISIT_NAMED_PARAMETER_DECL,
   VISIT_REQUIRED_INITIALIZING_FORMAL_DECL,
   VISIT_OPTIONAL_INITIALIZING_FORMAL_DECL,
   VISIT_NAMED_INITIALIZING_FORMAL_DECL,
 
   ERROR_UNRESOLVED_POSTFIX,
 
   // TODO(johnniwinther): Add tests for more error cases.
 }