Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(56)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/css/nth-child-of-pseudo-element-assert.html
Issue
1108783002
:
Don't cache nth-indices of pseudo elements. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Early return for pseudo elements in NthIndexCache.
Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/css/nth-child-of-pseudo-element-assert.html
LayoutTests/fast/css/nth-child-of-pseudo-element-assert-expected.txt
Source/core/dom/NthIndexCache.h
Source/core/dom/NthIndexCache.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
LayoutTests/fast/css/nth-child-of-pseudo-element-assert-expected.txt »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!DOCTYPE html>
2
<style>
3
div::before {
4
position: relative;
5
overflow: scroll;
6
display: block;
7
width: 100px;
8
height: 100px;
9
content: "."
10
}
11
12
:nth-child(13)::-webkit-scrollbar {
13
color: pink;
14
}
15
</style>
16
<script>
17
if (window.testRunner)
18
testRunner.dumpAsText();
19
</script>
20
<p>This test should not trigger any ASSERTs.</p>
21
<div></div>
OLD
NEW
« no previous file with comments
|
« no previous file
|
LayoutTests/fast/css/nth-child-of-pseudo-element-assert-expected.txt »
('j') |
no next file with comments »
Issue 1108783002: Don't cache nth-indices of pseudo elements. (Closed)
Created 5 years, 7 months ago by rune
Modified 5 years, 7 months ago
Reviewers: esprehn
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 1
This is Rietveld
408576698
Chromium Code Reviews
Issue 1108783002:
Don't cache nth-indices of pseudo elements. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master