Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 1108783002: Don't cache nth-indices of pseudo elements. (Closed)

Created:
5 years, 8 months ago by rune
Modified:
5 years, 7 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Don't cache nth-indices of pseudo elements. A pseudo element is not found in its parent's child list. That caused an assert while trying to cache the nth-index for a ::before element while matching style for the ::before element's scrollbar pseudo elements. Instead, skip the caching part and traverse siblings to fall back to the behavior we had before the NthIndexCache. Trying to get custom scrollbar style for pseudo elements with scrolling overflow will not work, but never did. It's not currently possible to match ::before::-webkit-scrollbar, and a universal ::-webkit-scrollbar will not match scrollbars in pseudo elements like ::before, either. R=esprehn@chromium.org BUG=481495 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194728

Patch Set 1 #

Total comments: 1

Patch Set 2 : Early return for pseudo elements in NthIndexCache. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
A LayoutTests/fast/css/nth-child-of-pseudo-element-assert.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/nth-child-of-pseudo-element-assert-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/NthIndexCache.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/dom/NthIndexCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rune
5 years, 8 months ago (2015-04-27 13:14:15 UTC) #1
rune
PTAL
5 years, 7 months ago (2015-04-29 10:43:22 UTC) #2
esprehn
lgtm, but it'd be nicer to move the condition to a separate one. https://codereview.chromium.org/1108783002/diff/1/Source/core/dom/NthIndexCache.h File ...
5 years, 7 months ago (2015-04-30 01:03:52 UTC) #3
rune
On 2015/04/30 01:03:52, esprehn wrote: > lgtm, but it'd be nicer to move the condition ...
5 years, 7 months ago (2015-04-30 08:22:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108783002/20001
5 years, 7 months ago (2015-04-30 08:22:51 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 11:08:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194728

Powered by Google App Engine
This is Rietveld 408576698