Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1108773002: [media] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
Reviewers:
xhwang
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, eme-reviews_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, hguihot+watch_chromium.org, wjia+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in src/media. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/902e992a9b6447028bf8d4f3540892c425984b8f Cr-Commit-Position: refs/heads/master@{#327075}

Patch Set 1 #

Patch Set 2 : Fixing nits #

Patch Set 3 : Fixed build break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -41 lines) Patch
M media/audio/audio_input_controller.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/audio_manager_base.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/base/android/media_decoder_job.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/android/media_drm_bridge.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/android/media_player_android.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/bind_to_current_loop.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/base/fake_text_track_stream.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M media/base/serial_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmoduleaccess_impl.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/test/utility/tap_proxy.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M media/cast/test/utility/udp_proxy.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M media/cast/test/utility/udp_proxy_main.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cdm/default_cdm_factory.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M media/filters/clockless_video_frame_scheduler.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/default_media_permission.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/fake_demuxer_stream.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/video/capture/linux/video_capture_device_chromeos.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/video/capture/mac/video_capture_device_factory_mac_unittest.mm View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/video/capture/mac/video_capture_device_mac.mm View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/video/capture/video_capture_device_unittest.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
anujsharma
PTAL
5 years, 8 months ago (2015-04-27 13:45:47 UTC) #2
xhwang
LGTM We need to do this for content/{renderer|browser}/media/ as well.
5 years, 8 months ago (2015-04-27 16:00:19 UTC) #3
anujsharma
On 2015/04/27 16:00:19, xhwang wrote: > LGTM > > We need to do this for ...
5 years, 8 months ago (2015-04-27 17:35:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108773002/40001
5 years, 8 months ago (2015-04-27 17:37:05 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-27 18:23:53 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/902e992a9b6447028bf8d4f3540892c425984b8f Cr-Commit-Position: refs/heads/master@{#327075}
5 years, 8 months ago (2015-04-27 18:24:49 UTC) #9
xhwang
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1105163004/ by xhwang@chromium.org. ...
5 years, 8 months ago (2015-04-27 21:39:35 UTC) #10
xhwang
On 2015/04/27 21:39:35, xhwang wrote: > A revert of this CL (patchset #3 id:40001) has ...
5 years, 8 months ago (2015-04-27 21:42:59 UTC) #11
anujsharma
On 2015/04/27 21:42:59, xhwang wrote: > On 2015/04/27 21:39:35, xhwang wrote: > > A revert ...
5 years, 8 months ago (2015-04-28 04:16:29 UTC) #12
xhwang
On 2015/04/28 04:16:29, anujsharma wrote: > On 2015/04/27 21:42:59, xhwang wrote: > > On 2015/04/27 ...
5 years, 8 months ago (2015-04-28 04:22:36 UTC) #13
anujsharma
5 years, 8 months ago (2015-04-28 04:27:16 UTC) #14
Message was sent while issue was closed.
On 2015/04/28 04:22:36, xhwang wrote:
> On 2015/04/28 04:16:29, anujsharma wrote:
> > On 2015/04/27 21:42:59, xhwang wrote:
> > > On 2015/04/27 21:39:35, xhwang wrote:
> > > > A revert of this CL (patchset #3 id:40001) has been created in
> > > > https://codereview.chromium.org/1105163004/ by
mailto:xhwang@chromium.org.
> > > > 
> > > > The reason for reverting is: see
> > > > https://code.google.com/p/chromium/issues/detail?id=481632.
> > > 
> > > mailto:anujk.sharma@samsung.com: Sorry that I reverted this CL. It seems
> this
> > breaking
> > > some mac bots. Please see the bug for details. Wondering whether you can
> help
> > > fix those and reland your CL? I'd be happy to review again. Thanks for
> working
> > > on this!
> > 
> > Thanks xhwang for vouching this on my behalf.
> > I will try to look into the issue and will send the CL once issue is fixed.
> > 
> > Is there any way to test during trybot for
> >
>
http://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.9%20Release%20...
> > case in order to regenerate the issue.
> > 
> > Thanks !!
> 
> I am not sure. Can you follow up in the bug?

Ok sure!!

thank you!

Powered by Google App Engine
This is Rietveld 408576698