Add tests for input method focusing to Widget interactive ui tests.

Add tests for input method focusing to Widget interactive ui tests.

BUG=474828
TES=Verified on local linux box.

Committed: https://crrev.com/3709fd81eb4fe812f88c00c2b750e748f515fe31
Cr-Commit-Position: refs/heads/master@{#327286}

[Shu Chen, 2015-04-27 04:04:47]

Sadrul, can you please review this cl? Thanks

[Shu Chen, 2015-04-27 15:25:11]

shuchen@chromium.org changed reviewers:
+ sadrul@chromium.org

[Shu Chen, 2015-04-27 15:25:12]

Sadrul, can you please review this cl? Thanks

[sadrul, 2015-04-28 05:12:57]

lgtm

https://codereview.chromium.org/1108733002/diff/60001/ui/views/widget/widget_...
File ui/views/widget/widget_interactive_uitest.cc (right):

https://codereview.chromium.org/1108733002/diff/60001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:357:
root_window2->GetHost()->GetAcceleratedWidget());
Use the new ActivatePlatformWindowSync (here and elsewhere where
::SetActiveWindow() is used)?

https://codereview.chromium.org/1108733002/diff/60001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:1489: #if !defined(OS_CHROMEOS)  //
Window::Blur doesn't work for CrOS
Is there a bug for this? Do we know why Blur doesn't work on chromeos?

https://codereview.chromium.org/1108733002/diff/60001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:1596: TEST_F(WidgetTestInteractive,
InputMethodFocus_textfield) {
For each test, please add a comment explaining what the test is doing.

[Shu Chen, 2015-04-28 06:46:29]

https://codereview.chromium.org/1108733002/diff/60001/ui/views/widget/widget_...
File ui/views/widget/widget_interactive_uitest.cc (right):

https://codereview.chromium.org/1108733002/diff/60001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:357:
root_window2->GetHost()->GetAcceleratedWidget());
On 2015/04/28 05:12:57, sadrul wrote:
> Use the new ActivatePlatformWindowSync (here and elsewhere where
> ::SetActiveWindow() is used)?

Done.

https://codereview.chromium.org/1108733002/diff/60001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:1489: #if !defined(OS_CHROMEOS)  //
Window::Blur doesn't work for CrOS
On 2015/04/28 05:12:57, sadrul wrote:
> Is there a bug for this? Do we know why Blur doesn't work on chromeos?

There is no bug. Please see my explanation in the latest code comment.

https://codereview.chromium.org/1108733002/diff/60001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:1596: TEST_F(WidgetTestInteractive,
InputMethodFocus_textfield) {
On 2015/04/28 05:12:57, sadrul wrote:
> For each test, please add a comment explaining what the test is doing.

Done.

[Shu Chen, 2015-04-28 07:40:38]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2015-04-28 07:40:38]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1108733002/#ps80001
(title: "addressed comments.")

[commit-bot: I haz the power, 2015-04-28 07:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108733002/80001

[commit-bot: I haz the power, 2015-04-28 08:03:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 08:03:17]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Shu Chen, 2015-04-28 08:36:32]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2015-04-28 08:36:32]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1108733002/#ps100001
(title: "guard the tests by USE_AURA")

[commit-bot: I haz the power, 2015-04-28 08:36:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108733002/100001

[commit-bot: I haz the power, 2015-04-28 09:04:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 09:04:59]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Shu Chen, 2015-04-28 09:06:52]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2015-04-28 09:06:52]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1108733002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-04-28 09:07:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108733002/120001

[commit-bot: I haz the power, 2015-04-28 09:37:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 09:37:04]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Shu Chen, 2015-04-28 14:12:59]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2015-04-28 14:12:59]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1108733002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-04-28 14:13:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108733002/140001

[commit-bot: I haz the power, 2015-04-28 14:48:31]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-04-28 14:49:19]

Patchset 8 (id:??) landed as
https://crrev.com/3709fd81eb4fe812f88c00c2b750e748f515fe31
Cr-Commit-Position: refs/heads/master@{#327286}

[tapted, 2015-05-01 01:54:25]

tapted@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2015-05-01 01:54:26]

https://codereview.chromium.org/1108733002/diff/140001/ui/views/widget/widget...
File ui/views/widget/widget_interactive_uitest.cc (right):

https://codereview.chromium.org/1108733002/diff/140001/ui/views/widget/widget...
ui/views/widget/widget_interactive_uitest.cc:249: void
ActivatePlatformWindowSync(Widget* widget) {
Hi There! I'd like to get these tests working on Mac. I'm happy to do this.

First, I just had a question about the linux behaviour here -- did you first try
just `ActivateSync()` above and have it fail? (do you know why?)

Activation on mac is asynchronous like on Linux-desktop, which is why
ActivateSync came about. I'm hoping we can get all tests using the
cross-platform APIs in views::Widget.

Thanks!

[tapted, 2015-05-01 09:10:17]

https://codereview.chromium.org/1108733002/diff/140001/ui/views/widget/widget...
File ui/views/widget/widget_interactive_uitest.cc (right):

https://codereview.chromium.org/1108733002/diff/140001/ui/views/widget/widget...
ui/views/widget/widget_interactive_uitest.cc:249: void
ActivatePlatformWindowSync(Widget* widget) {
On 2015/05/01 01:54:25, tapted wrote:
> Hi There! I'd like to get these tests working on Mac. I'm happy to do this.
> 
> First, I just had a question about the linux behaviour here -- did you first
try
> just `ActivateSync()` above and have it fail? (do you know why?)
> 
> Activation on mac is asynchronous like on Linux-desktop, which is why
> ActivateSync came about. I'm hoping we can get all tests using the
> cross-platform APIs in views::Widget.
> 
> Thanks!

Looks like ActivateSync() can do the job on Linux. I've got most things working
(including Mac) in https://codereview.chromium.org/1118173003/ if you'd like a
peek. Windows is that last one to investigate, but I'll do that next week.

[Shu Chen, 2015-05-05 02:30:40]

On 2015/05/01 09:10:17, tapted wrote:
>
https://codereview.chromium.org/1108733002/diff/140001/ui/views/widget/widget...
> File ui/views/widget/widget_interactive_uitest.cc (right):
> 
>
https://codereview.chromium.org/1108733002/diff/140001/ui/views/widget/widget...
> ui/views/widget/widget_interactive_uitest.cc:249: void
> ActivatePlatformWindowSync(Widget* widget) {
> On 2015/05/01 01:54:25, tapted wrote:
> > Hi There! I'd like to get these tests working on Mac. I'm happy to do this.
> > 
> > First, I just had a question about the linux behaviour here -- did you first
> try
> > just `ActivateSync()` above and have it fail? (do you know why?)
> > 
> > Activation on mac is asynchronous like on Linux-desktop, which is why
> > ActivateSync came about. I'm hoping we can get all tests using the
> > cross-platform APIs in views::Widget.
> > 
> > Thanks!
> 
> Looks like ActivateSync() can do the job on Linux. I've got most things
working
> (including Mac) in https://codereview.chromium.org/1118173003/ if you'd like a
> peek. Windows is that last one to investigate, but I'll do that next week.

Thanks for catching this. Actually I don't know why ActivateSync() doesn't work
for Linux when I added the tests.
Some code was copied from desktop_window_tree_host_x11_interactive_uitest.cc
where the tests work well for linux-x11.
Just saw your CL to clean up the tests, and thanks for doing that!