Fix bug in the sminess propagation that limited optimization opportunities.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
@@ skipping 1316 matching lines @@
   for (intptr_t i = 0; i < worklist_.length(); i++) {
     PhiInstr* phi = worklist_[i];
     ASSERT(phi->GetPropagatedCid() == kDynamicCid);
     phi->SetPropagatedCid(kSmiCid);
 
     // Append all phis that use this phi and can potentially be smi to the
     // end of worklist.
     for (Value* use = phi->input_use_list();
          use != NULL;
          use = use->next_use()) {
-      PhiInstr* phi_use = use->definition()->AsPhi();
+      PhiInstr* phi_use = use->instruction()->AsPhi();
       if ((phi_use != NULL) &&
           (phi_use->GetPropagatedCid() == kDynamicCid) &&
           IsPossiblySmiPhi(phi_use)) {
         AddToWorklist(phi_use);
       }
     }
   }
 
   // Now unmark phis that are not definitely smi: that is have only
   // smi operands.
   while (!worklist_.is_empty()) {
     PhiInstr* phi = RemoveLastFromWorklist();
     if (!IsDefinitelySmiPhi(phi)) {
       // Phi result is not a smi. Propagate this fact to phis that depend on it.
       phi->SetPropagatedCid(kDynamicCid);
       for (Value* use = phi->input_use_list();
            use != NULL;
            use = use->next_use()) {
-        PhiInstr* phi_use = use->definition()->AsPhi();
+        PhiInstr* phi_use = use->instruction()->AsPhi();
         if ((phi_use != NULL) && (phi_use->GetPropagatedCid() == kSmiCid)) {
           AddToWorklist(phi_use);
         }
       }
     }
   }
 }
 
 
 void SminessPropagator::PropagateSminessRecursive(BlockEntryInstr* block) {
@@ skipping 1926 matching lines @@
 
   if (FLAG_trace_constant_propagation) {
     OS::Print("\n==== After constant propagation ====\n");
     FlowGraphPrinter printer(*graph_);
     printer.PrintBlocks();
   }
 }
 
 
 }  // namespace dart