chrome/browser/extensions/crx_installer_browsertest.cc - Issue 11087071: Making ShowExtensionInstallDialog a callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 11087071: Making ShowExtensionInstallDialog a callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/crx_installer_browsertest.cc

diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc

index 8f3c1e0b1cca6055b33214dbce316376fc38660c..aea96aae221d786692ab82c811baee9267bd8f50 100644

--- a/chrome/browser/extensions/crx_installer_browsertest.cc

+++ b/chrome/browser/extensions/crx_installer_browsertest.cc

@@ -47,7 +47,8 @@ class MockInstallPrompt : public ExtensionInstallPrompt {

// Overriding some of the ExtensionInstallUI API.

void ConfirmInstall(Delegate* delegate,

- const Extension* extension) {

+ const Extension* extension,

+ scoped_refptr<ExtensionInstallDialog> dialog) {

confirmation_requested_ = true;

delegate->InstallUIProceed();

}