chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm - Issue 11087071: Making ShowExtensionInstallDialog a callback

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm

Issue 11087071: Making ShowExtensionInstallDialog a callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/extensions/extension_install_prompt.cc ('K') | « chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm ('k') | chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"	5 #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"

6	6

7 #include "base/auto_reset.h"	7 #include "base/auto_reset.h"

8 #include "base/i18n/rtl.h"	8 #include "base/i18n/rtl.h"

9 #include "base/mac/bundle_locations.h"	9 #include "base/mac/bundle_locations.h"

10 #include "base/mac/mac_util.h"	10 #include "base/mac/mac_util.h"

11 #include "base/string_util.h"	11 #include "base/string_util.h"

12 #include "base/sys_string_conversions.h"	12 #include "base/sys_string_conversions.h"

13 #include "base/utf_string_conversions.h"	13 #include "base/utf_string_conversions.h"

14 #include "chrome/browser/extensions/bundle_installer.h"	14 #include "chrome/browser/extensions/bundle_installer.h"

15 #include "chrome/browser/extensions/extension_install_dialog.h"

16 #include "chrome/common/extensions/extension.h"	15 #include "chrome/common/extensions/extension.h"

17 #include "content/public/browser/page_navigator.h"	16 #include "content/public/browser/page_navigator.h"

18 #include "grit/generated_resources.h"	17 #include "grit/generated_resources.h"

19 #include "skia/ext/skia_utils_mac.h"	18 #include "skia/ext/skia_utils_mac.h"

20 #import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h"	19 #import "third_party/GTM/AppKit/GTMUILocalizerAndLayoutTweaker.h"

21 #include "ui/base/l10n/l10n_util.h"	20 #include "ui/base/l10n/l10n_util.h"

22 #include "ui/base/l10n/l10n_util_mac.h"	21 #include "ui/base/l10n/l10n_util_mac.h"

23 #include "ui/gfx/image/image_skia_util_mac.h"	22 #include "ui/gfx/image/image_skia_util_mac.h"

24	23

25 using content::OpenURLParams;	24 using content::OpenURLParams;

(...skipping 462 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
488 [warnings addObject:	487 [warnings addObject:

489 [self buildItemWithTitle:SysUTF16ToNSString(prompt.GetOAuthHeading())	488 [self buildItemWithTitle:SysUTF16ToNSString(prompt.GetOAuthHeading())

490 isGroupItem:YES	489 isGroupItem:YES

491 children:children]];	490 children:children]];

492 }	491 }

493	492

494 return warnings;	493 return warnings;

495 }	494 }

496	495

497 @end	496 @end

OLD	NEW