Ignore certain keys when hiding the cursor

Ignore certain keys when hiding the cursor


BUG=153157
Test=Visual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161386

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161402

[DaveMoore, 2012-10-10 21:17:02]

Note: Until we remove unclutter we will still hide the cursor on some of these
keys. That will come soon, once we add the capability to Chrome to notify the
trackpad (via X) that the cursor is hidden.

[Daniel Erat, 2012-10-10 21:34:04]

https://codereview.chromium.org/11087064/diff/1/ui/aura/shared/compound_event...
File ui/aura/shared/compound_event_filter.cc (right):

https://codereview.chromium.org/11087064/diff/1/ui/aura/shared/compound_event...
ui/aura/shared/compound_event_filter.cc:36: bool
ShouldHideCursorOnKeyEvent(const ui::KeyEvent* event) {
nit: can you make the parameter be a const reference instead?

https://codereview.chromium.org/11087064/diff/1/ui/aura/shared/compound_event...
ui/aura/shared/compound_event_filter.cc:67: ignored_keys.insert(ui::VKEY_POWER);
you need to set inited to true here

[DaveMoore, 2012-10-10 21:47:33]

https://codereview.chromium.org/11087064/diff/1/ui/aura/shared/compound_event...
File ui/aura/shared/compound_event_filter.cc (right):

https://codereview.chromium.org/11087064/diff/1/ui/aura/shared/compound_event...
ui/aura/shared/compound_event_filter.cc:36: bool
ShouldHideCursorOnKeyEvent(const ui::KeyEvent* event) {
On 2012/10/10 21:34:05, Daniel Erat wrote:
> nit: can you make the parameter be a const reference instead?

Done.

https://codereview.chromium.org/11087064/diff/1/ui/aura/shared/compound_event...
ui/aura/shared/compound_event_filter.cc:67: ignored_keys.insert(ui::VKEY_POWER);
On 2012/10/10 21:34:05, Daniel Erat wrote:
> you need to set inited to true here

Done.

[Daniel Erat, 2012-10-10 21:50:02]

lgtm

[DaveMoore, 2012-10-11 04:10:40]

ben: OWNERS please

[Yusuke Sato, 2012-10-11 06:58:38]

drive-by:

LGTM with nits.

https://codereview.chromium.org/11087064/diff/4002/ui/aura/shared/compound_ev...
File ui/aura/shared/compound_event_filter.cc (right):

https://codereview.chromium.org/11087064/diff/4002/ui/aura/shared/compound_ev...
ui/aura/shared/compound_event_filter.cc:56: // ChromeOS command keys.
nit: They're also media keys, actually (Chromebook's top-row keys always
generate F1-F10). I think you can consolidate 57 and 61 into one loop.

https://codereview.chromium.org/11087064/diff/4002/ui/aura/shared/compound_ev...
ui/aura/shared/compound_event_filter.cc:67: ignored_keys.insert(ui::VKEY_POWER);
#if defined(OS_CHROMEOS) might be necessary not to make win_aura bot red since
VKEY_POWER is not defined for Windows.

https://codereview.chromium.org/11087064/diff/4002/ui/aura/shared/compound_ev...
ui/aura/shared/compound_event_filter.cc:67: ignored_keys.insert(ui::VKEY_POWER);
VKEY_WLAN, VKEY_BRIGHTNESS_DOWN/UP, VKEY_KEY_BRIGHTNESS_DOWN/UP are also
(posix-only) media keys.

[Ben Goodger (Google), 2012-10-11 20:03:39]

lgtm