Issue 11087014: Revert 160696 - Decouple EventClientImpl and root window. Check containers on the same root window …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11087014: Revert 160696 - Decouple EventClientImpl and root window. Check containers on the same root window … (Closed)

Created:
8 years, 2 months ago by Ryan Hamilton

Modified:
8 years, 2 months ago

Reviewers:
oshima

CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 160696 - Decouple EventClientImpl and root window. Check containers on the same root window as focused window when testing if the focused window can receive events. This was causing lock screen to lose focus when mouse is clicked on another root window. This Cl also adds a debug build/linux desktop only shortcut (F11) to lock/shutdown. BUG=152982 TEST=covered by test. Review URL: https://chromiumcodereview.appspot.com/11047030 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160707

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -155 lines)			Patch
M	ash/accelerators/accelerator_controller.cc	View	3 chunks	+4 lines, -31 lines	0 comments	Download
M	ash/accelerators/accelerator_table.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View	4 chunks	+0 lines, -16 lines	0 comments	Download
M	ash/extended_desktop_unittest.cc	View	4 chunks	+0 lines, -70 lines	0 comments	Download
M	ash/root_window_controller.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	ash/root_window_controller.cc	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	ash/shell.h	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	ash/shell.cc	View	4 chunks	+0 lines, -10 lines	0 comments	Download
M	ash/wm/event_client_impl.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	ash/wm/event_client_impl.cc	View	1 chunk	+12 lines, -10 lines	0 comments	Download
M	ash/wm/power_button_controller.cc	View	2 chunks	+0 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm