Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: Source/platform/AsyncMethodRunner.h

Issue 1108663002: Do not invoke async method on a GC-unreachable object. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 if (m_timer.isActive()) 113 if (m_timer.isActive())
114 m_timer.stop(); 114 m_timer.stop();
115 } 115 }
116 116
117 bool isActive() const 117 bool isActive() const
118 { 118 {
119 return m_timer.isActive(); 119 return m_timer.isActive();
120 } 120 }
121 121
122 private: 122 private:
123 void fired(Timer<AsyncMethodRunner<TargetClass>>*) { (m_object->*m_method)() ; } 123 void fired(Timer<AsyncMethodRunner<TargetClass>>*)
124 {
125 if (!TimerIsObjectAliveTrait<TargetClass>::isHeapObjectAlive(m_object))
haraken 2015/04/25 08:02:07 Can we have a comment to mention that this hack wi
sof 2015/04/25 09:10:26 Good idea, done.
126 return;
127 (m_object->*m_method)();
128 }
124 129
125 Timer<AsyncMethodRunner<TargetClass>> m_timer; 130 Timer<AsyncMethodRunner<TargetClass>> m_timer;
126 131
127 // FIXME: oilpan: AsyncMethodRunner should be moved to the heap and m_object should be traced. 132 // TODO(Oilpan): AsyncMethodRunner should be moved to the heap and m_object should be traced.
128 // This raw pointer is safe as long as AsyncMethodRunner<X> is held by the X itself 133 // This raw pointer is safe as long as AsyncMethodRunner<X> is held by the X itself
129 // (That's the case in the current code base). 134 // (That's the case in the current code base).
130 GC_PLUGIN_IGNORE("363031") 135 GC_PLUGIN_IGNORE("363031")
131 TargetClass* m_object; 136 TargetClass* m_object;
132 TargetMethod m_method; 137 TargetMethod m_method;
133 138
134 bool m_suspended; 139 bool m_suspended;
135 bool m_runWhenResumed; 140 bool m_runWhenResumed;
136 }; 141 };
137 142
138 } 143 }
139 144
140 #endif 145 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698