Handle single-byte exports in SafeBrowsingModuleVerifierWinTest.NewVerifyModuleExportModified.

Handle single-byte exports in  SafeBrowsingModuleVerifierWinTest.NewVerifyModuleExportModified.

This fixes a test failure on clang bots.

BUG=480546
R=anthonyvd@chromium.org, thakis@chromium.org

Committed: https://crrev.com/4e30029e92cc7afdbe1419d3799f122344b750f8
Cr-Commit-Position: refs/heads/master@{#326868}

[grt (UTC plus 2), 2015-04-24 19:45:49]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-24 19:46:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108643002/1

[grt (UTC plus 2), 2015-04-24 19:47:00]

Anthony: please take a look. You too, Nico, if you wish. Thanks.

[Nico, 2015-04-24 19:48:56]

lgtm, makes sense

[anthonyvd, 2015-04-24 20:02:42]

On 2015/04/24 19:47:00, grt wrote:
> Anthony: please take a look. You too, Nico, if you wish. Thanks.

If I understand correctly, the clang bots would emit only 1 byte at the first
export's address and so a modification in each export would be next to each
other and be picked up as one.

If so, lgtm

[commit-bot: I haz the power, 2015-04-24 20:09:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 20:09:10]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2015-04-24 20:30:03]

On 2015/04/24 20:02:42, anthonyvd wrote:
> On 2015/04/24 19:47:00, grt wrote:
> > Anthony: please take a look. You too, Nico, if you wish. Thanks.
> 
> If I understand correctly, the clang bots would emit only 1 byte at the first
> export's address and so a modification in each export would be next to each
> other and be picked up as one.

Exactly.

> If so, lgtm

Thanks.

[grt (UTC plus 2), 2015-04-24 20:30:06]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2015-04-24 20:31:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108643002/1

[commit-bot: I haz the power, 2015-04-24 20:33:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-24 20:34:00]

Patchset 1 (id:??) landed as
https://crrev.com/4e30029e92cc7afdbe1419d3799f122344b750f8
Cr-Commit-Position: refs/heads/master@{#326868}

[Nico, 2015-04-24 20:34:08]

On Fri, Apr 24, 2015 at 1:02 PM, <anthonyvd@chromium.org> wrote:

> On 2015/04/24 19:47:00, grt wrote:
>
>> Anthony: please take a look. You too, Nico, if you wish. Thanks.
>>
>
> If I understand correctly, the clang bots would emit only 1 byte at the
> first
> export's address and so a modification in each export would be next to each
> other and be picked up as one.
>

(Not all of them, only the ones doing official builds as these optimize for
size.)


>
> If so, lgtm
>
> https://codereview.chromium.org/1108643002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.