Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1108633002: [New Multicolumn] Only the nearest ancestral flow thread may serve as a containing flow thread. (Closed)

Created:
5 years, 8 months ago by mstensho (USE GERRIT)
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] Only the nearest ancestral flow thread may serve as a containing flow thread. Prevent spanners and out-of-flow objects from returning an outer flow thread (nested multicol). If the nearest flow thread doesn't serve as a flow thread containing block, then have no flow thread containing block at all. This seals each multicol context a bit better from any other multicol contexts that may exist. Also removed a suspicious call to parent()->flowThreadContainingBlock(). This was required during early development stages of column-span:all support, but not any more. BUG=480965 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194529

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
A LayoutTests/fast/multicol/span/in-nested-multicol-with-list-item.html View 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/span/in-nested-multicol-with-list-item-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 2 chunks +13 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutState.cpp View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
5 years, 8 months ago (2015-04-24 19:40:03 UTC) #1
dsinclair
lgtm w/ nit. https://codereview.chromium.org/1108633002/diff/1/Source/core/layout/LayoutObject.cpp File Source/core/layout/LayoutObject.cpp (right): https://codereview.chromium.org/1108633002/diff/1/Source/core/layout/LayoutObject.cpp#newcode621 Source/core/layout/LayoutObject.cpp:621: return 0; nit: nullptr
5 years, 7 months ago (2015-04-27 14:45:24 UTC) #2
mstensho (USE GERRIT)
https://codereview.chromium.org/1108633002/diff/1/Source/core/layout/LayoutObject.cpp File Source/core/layout/LayoutObject.cpp (right): https://codereview.chromium.org/1108633002/diff/1/Source/core/layout/LayoutObject.cpp#newcode621 Source/core/layout/LayoutObject.cpp:621: return 0; On 2015/04/27 14:45:24, dsinclair wrote: > nit: ...
5 years, 7 months ago (2015-04-27 16:08:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108633002/20001
5 years, 7 months ago (2015-04-27 16:08:44 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 17:22:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194529

Powered by Google App Engine
This is Rietveld 408576698