content/browser/devtools/protocol/devtools_protocol_handler_generator.py - Issue 1108613002: Change virtual to override in devtools generator code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_handler_generator.py

Issue 1108613002: Change virtual to override in devtools generator code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/protocol/devtools_protocol_handler_generator.py

diff --git a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py

index 3f539ec829a7f4dd4ca234439bfc1d953200d286..cc2aa130b6840e6f2585bc825df34929bf91f3dc 100755

--- a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py

+++ b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py

@@ -207,7 +207,7 @@ namespace ${domain} {

class Client : public DevToolsProtocolClient {

public:

explicit Client(const RawMessageCallback& raw_message_callback);

- virtual ~Client();

+ ~Client() override;

${methods}\

};

« no previous file with comments | « no previous file | no next file » | no next file with comments »