Issue 11086085: Initialize the PolicyStatusCollector.

Issue 11086085: Initialize the PolicyStatusCollector. (Closed)

Created:
8 years, 2 months ago by Joao da Silva

Modified:
8 years, 2 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Initialize the PolicyStatusCollector. BUG=100869 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161552

Patch Set 2 : rebase, rename #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -8 lines)			Patch
	M	chrome/browser/policy/browser_policy_connector.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/policy/policy_browsertest.cc	View	1	3 chunks	+69 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

LGTM with a nit. https://codereview.chromium.org/11086085/diff/1/chrome/browser/policy/policy_browsertest.cc File chrome/browser/policy/policy_browsertest.cc (right): https://codereview.chromium.org/11086085/diff/1/chrome/browser/policy/policy_browsertest.cc#newcode1586 chrome/browser/policy/policy_browsertest.cc:1586: // started. Seems like premature ...

8 years, 2 months ago (2012-10-12 08:14:21 UTC) #2

Joao da Silva

Thanks for the review! https://codereview.chromium.org/11086085/diff/1/chrome/browser/policy/policy_browsertest.cc File chrome/browser/policy/policy_browsertest.cc (right): https://codereview.chromium.org/11086085/diff/1/chrome/browser/policy/policy_browsertest.cc#newcode1586 chrome/browser/policy/policy_browsertest.cc:1586: // started. On 2012/10/12 08:14:21, ...

8 years, 2 months ago (2012-10-12 08:26:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/11086085/6001

8 years, 2 months ago (2012-10-12 08:26:26 UTC) #4

Change committed as 161552

Expand Messages | Collapse Messages