Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: runtime/tools/make_version.py

Issue 11086066: - Avoid calling Unix commands on Windows. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/tools/make_version.py
===================================================================
--- runtime/tools/make_version.py (revision 13516)
+++ runtime/tools/make_version.py (working copy)
@@ -8,6 +8,7 @@
import pwd
import sys
import subprocess
+import platform
import getpass
from os.path import join
import time
@@ -31,6 +32,9 @@
return proc.communicate()[0].split('\n')[4].split(' ')[1]
def makeVersionString(version_file):
+ id = platform.system()
+ if id == 'Windows' or id == 'Microsoft':
+ return '0.0.0.0'
major = getVersionPart(version_file, 'MAJOR')
minor = getVersionPart(version_file, 'MINOR')
build = getVersionPart(version_file, 'BUILD')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698