Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: cc/CCKeyframedAnimationCurve.cpp

Issue 11086053: Revert 161133 - [cc] Use base ptr types for cc's CSS animation classes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/CCKeyframedAnimationCurve.h ('k') | cc/CCKeyframedAnimationCurveTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/CCKeyframedAnimationCurve.cpp
===================================================================
--- cc/CCKeyframedAnimationCurve.cpp (revision 161134)
+++ cc/CCKeyframedAnimationCurve.cpp (working copy)
@@ -6,6 +6,8 @@
#include "CCKeyframedAnimationCurve.h"
+#include <wtf/OwnPtr.h>
+
using WebKit::WebTransformationMatrix;
namespace cc {
@@ -13,34 +15,36 @@
namespace {
template <class Keyframe>
-void insertKeyframe(scoped_ptr<Keyframe> keyframe, ScopedPtrVector<Keyframe>& keyframes)
+void insertKeyframe(PassOwnPtr<Keyframe> popKeyframe, OwnPtrVector<Keyframe>& keyframes)
{
+ OwnPtr<Keyframe> keyframe = popKeyframe;
+
// Usually, the keyframes will be added in order, so this loop would be unnecessary and
// we should skip it if possible.
if (!keyframes.isEmpty() && keyframe->time() < keyframes.last()->time()) {
for (size_t i = 0; i < keyframes.size(); ++i) {
if (keyframe->time() < keyframes[i]->time()) {
- keyframes.insert(i, keyframe.Pass());
+ keyframes.insert(i, keyframe.release());
return;
}
}
}
- keyframes.append(keyframe.Pass());
+ keyframes.append(keyframe.release());
}
-scoped_ptr<CCTimingFunction> cloneTimingFunction(const CCTimingFunction* timingFunction)
+PassOwnPtr<CCTimingFunction> cloneTimingFunction(const CCTimingFunction* timingFunction)
{
ASSERT(timingFunction);
- scoped_ptr<CCAnimationCurve> curve(timingFunction->clone());
- return scoped_ptr<CCTimingFunction>(static_cast<CCTimingFunction*>(curve.release()));
+ OwnPtr<CCAnimationCurve> curve(timingFunction->clone());
+ return adoptPtr(static_cast<CCTimingFunction*>(curve.leakPtr()));
}
} // namespace
-CCKeyframe::CCKeyframe(double time, scoped_ptr<CCTimingFunction> timingFunction)
+CCKeyframe::CCKeyframe(double time, PassOwnPtr<CCTimingFunction> timingFunction)
: m_time(time)
- , m_timingFunction(timingFunction.Pass())
+ , m_timingFunction(timingFunction)
{
}
@@ -58,13 +62,13 @@
return m_timingFunction.get();
}
-scoped_ptr<CCFloatKeyframe> CCFloatKeyframe::create(double time, float value, scoped_ptr<CCTimingFunction> timingFunction)
+PassOwnPtr<CCFloatKeyframe> CCFloatKeyframe::create(double time, float value, PassOwnPtr<CCTimingFunction> timingFunction)
{
- return make_scoped_ptr(new CCFloatKeyframe(time, value, timingFunction.Pass()));
+ return adoptPtr(new CCFloatKeyframe(time, value, timingFunction));
}
-CCFloatKeyframe::CCFloatKeyframe(double time, float value, scoped_ptr<CCTimingFunction> timingFunction)
- : CCKeyframe(time, timingFunction.Pass())
+CCFloatKeyframe::CCFloatKeyframe(double time, float value, PassOwnPtr<CCTimingFunction> timingFunction)
+ : CCKeyframe(time, timingFunction)
, m_value(value)
{
}
@@ -78,17 +82,18 @@
return m_value;
}
-scoped_ptr<CCFloatKeyframe> CCFloatKeyframe::clone() const
+PassOwnPtr<CCFloatKeyframe> CCFloatKeyframe::clone() const
{
- return CCFloatKeyframe::create(time(), value(), timingFunction() ? cloneTimingFunction(timingFunction()) : scoped_ptr<CCTimingFunction>()); }
+ return CCFloatKeyframe::create(time(), value(), timingFunction() ? cloneTimingFunction(timingFunction()) : nullptr);
+}
-scoped_ptr<CCTransformKeyframe> CCTransformKeyframe::create(double time, const WebKit::WebTransformOperations& value, scoped_ptr<CCTimingFunction> timingFunction)
+PassOwnPtr<CCTransformKeyframe> CCTransformKeyframe::create(double time, const WebKit::WebTransformOperations& value, PassOwnPtr<CCTimingFunction> timingFunction)
{
- return make_scoped_ptr(new CCTransformKeyframe(time, value, timingFunction.Pass()));
+ return adoptPtr(new CCTransformKeyframe(time, value, timingFunction));
}
-CCTransformKeyframe::CCTransformKeyframe(double time, const WebKit::WebTransformOperations& value, scoped_ptr<CCTimingFunction> timingFunction)
- : CCKeyframe(time, timingFunction.Pass())
+CCTransformKeyframe::CCTransformKeyframe(double time, const WebKit::WebTransformOperations& value, PassOwnPtr<CCTimingFunction> timingFunction)
+ : CCKeyframe(time, timingFunction)
, m_value(value)
{
}
@@ -102,14 +107,14 @@
return m_value;
}
-scoped_ptr<CCTransformKeyframe> CCTransformKeyframe::clone() const
+PassOwnPtr<CCTransformKeyframe> CCTransformKeyframe::clone() const
{
- return CCTransformKeyframe::create(time(), value(), timingFunction() ? cloneTimingFunction(timingFunction()) : scoped_ptr<CCTimingFunction>());
+ return CCTransformKeyframe::create(time(), value(), timingFunction() ? cloneTimingFunction(timingFunction()) : nullptr);
}
-scoped_ptr<CCKeyframedFloatAnimationCurve> CCKeyframedFloatAnimationCurve::create()
+PassOwnPtr<CCKeyframedFloatAnimationCurve> CCKeyframedFloatAnimationCurve::create()
{
- return make_scoped_ptr(new CCKeyframedFloatAnimationCurve);
+ return adoptPtr(new CCKeyframedFloatAnimationCurve);
}
CCKeyframedFloatAnimationCurve::CCKeyframedFloatAnimationCurve()
@@ -120,9 +125,9 @@
{
}
-void CCKeyframedFloatAnimationCurve::addKeyframe(scoped_ptr<CCFloatKeyframe> keyframe)
+void CCKeyframedFloatAnimationCurve::addKeyframe(PassOwnPtr<CCFloatKeyframe> keyframe)
{
- insertKeyframe(keyframe.Pass(), m_keyframes);
+ insertKeyframe(keyframe, m_keyframes);
}
double CCKeyframedFloatAnimationCurve::duration() const
@@ -130,12 +135,12 @@
return m_keyframes.last()->time() - m_keyframes.first()->time();
}
-scoped_ptr<CCAnimationCurve> CCKeyframedFloatAnimationCurve::clone() const
+PassOwnPtr<CCAnimationCurve> CCKeyframedFloatAnimationCurve::clone() const
{
- scoped_ptr<CCKeyframedFloatAnimationCurve> toReturn(CCKeyframedFloatAnimationCurve::create());
+ OwnPtr<CCKeyframedFloatAnimationCurve> toReturn(CCKeyframedFloatAnimationCurve::create());
for (size_t i = 0; i < m_keyframes.size(); ++i)
toReturn->addKeyframe(m_keyframes[i]->clone());
- return toReturn.PassAs<CCAnimationCurve>();
+ return toReturn.release();
}
float CCKeyframedFloatAnimationCurve::getValue(double t) const
@@ -160,9 +165,9 @@
return m_keyframes[i]->value() + (m_keyframes[i+1]->value() - m_keyframes[i]->value()) * progress;
}
-scoped_ptr<CCKeyframedTransformAnimationCurve> CCKeyframedTransformAnimationCurve::create()
+PassOwnPtr<CCKeyframedTransformAnimationCurve> CCKeyframedTransformAnimationCurve::create()
{
- return make_scoped_ptr(new CCKeyframedTransformAnimationCurve);
+ return adoptPtr(new CCKeyframedTransformAnimationCurve);
}
CCKeyframedTransformAnimationCurve::CCKeyframedTransformAnimationCurve()
@@ -173,9 +178,9 @@
{
}
-void CCKeyframedTransformAnimationCurve::addKeyframe(scoped_ptr<CCTransformKeyframe> keyframe)
+void CCKeyframedTransformAnimationCurve::addKeyframe(PassOwnPtr<CCTransformKeyframe> keyframe)
{
- insertKeyframe(keyframe.Pass(), m_keyframes);
+ insertKeyframe(keyframe, m_keyframes);
}
double CCKeyframedTransformAnimationCurve::duration() const
@@ -183,12 +188,12 @@
return m_keyframes.last()->time() - m_keyframes.first()->time();
}
-scoped_ptr<CCAnimationCurve> CCKeyframedTransformAnimationCurve::clone() const
+PassOwnPtr<CCAnimationCurve> CCKeyframedTransformAnimationCurve::clone() const
{
- scoped_ptr<CCKeyframedTransformAnimationCurve> toReturn(CCKeyframedTransformAnimationCurve::create());
+ OwnPtr<CCKeyframedTransformAnimationCurve> toReturn(CCKeyframedTransformAnimationCurve::create());
for (size_t i = 0; i < m_keyframes.size(); ++i)
toReturn->addKeyframe(m_keyframes[i]->clone());
- return toReturn.PassAs<CCAnimationCurve>();
+ return toReturn.release();
}
WebTransformationMatrix CCKeyframedTransformAnimationCurve::getValue(double t) const
« no previous file with comments | « cc/CCKeyframedAnimationCurve.h ('k') | cc/CCKeyframedAnimationCurveTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698