Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: webkit/compositor_bindings/WebAnimationImpl.cpp

Issue 11086053: Revert 161133 - [cc] Use base ptr types for cc's CSS animation classes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/compositor_bindings/WebAnimationImpl.cpp
===================================================================
--- webkit/compositor_bindings/WebAnimationImpl.cpp (revision 161134)
+++ webkit/compositor_bindings/WebAnimationImpl.cpp (working copy)
@@ -13,6 +13,7 @@
#include <public/WebAnimation.h>
#include <public/WebAnimationCurve.h>
#include <wtf/OwnPtr.h>
+#include <wtf/PassOwnPtr.h>
using cc::CCActiveAnimation;
@@ -33,7 +34,7 @@
groupId = nextGroupId++;
WebAnimationCurve::AnimationCurveType curveType = webCurve.type();
- scoped_ptr<cc::CCAnimationCurve> curve;
+ OwnPtr<cc::CCAnimationCurve> curve;
switch (curveType) {
case WebAnimationCurve::AnimationCurveTypeFloat: {
const WebFloatAnimationCurveImpl* floatCurveImpl = static_cast<const WebFloatAnimationCurveImpl*>(&webCurve);
@@ -46,7 +47,7 @@
break;
}
}
- m_animation = CCActiveAnimation::create(curve.Pass(), animationId, groupId, static_cast<cc::CCActiveAnimation::TargetProperty>(targetProperty));
+ m_animation = CCActiveAnimation::create(curve.release(), animationId, groupId, static_cast<cc::CCActiveAnimation::TargetProperty>(targetProperty));
}
WebAnimationImpl::~WebAnimationImpl()
@@ -103,11 +104,11 @@
m_animation->setAlternatesDirection(alternates);
}
-scoped_ptr<cc::CCActiveAnimation> WebAnimationImpl::cloneToCCAnimation()
+PassOwnPtr<cc::CCActiveAnimation> WebAnimationImpl::cloneToCCAnimation()
{
- scoped_ptr<cc::CCActiveAnimation> toReturn(m_animation->clone(cc::CCActiveAnimation::NonControllingInstance));
+ OwnPtr<cc::CCActiveAnimation> toReturn(m_animation->clone(cc::CCActiveAnimation::NonControllingInstance));
toReturn->setNeedsSynchronizedStartTime(true);
- return toReturn.Pass();
+ return toReturn.release();
}
} // namespace WebKit
« no previous file with comments | « webkit/compositor_bindings/WebAnimationImpl.h ('k') | webkit/compositor_bindings/WebFloatAnimationCurveImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698