lib/html/scripts/systemhtml.py - Issue 11086029: Better return types for window.location and window.history

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/scripts/systemhtml.py

Issue 11086029: Better return types for window.location and window.history (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/html/scripts/systemhtml.py

diff --git a/lib/html/scripts/systemhtml.py b/lib/html/scripts/systemhtml.py

index e96a578d364bbef54657091a22c43fcfa44d6617..203d88f3ac78d1ba7f9b6b590e740eff0fa7f5ea 100644

--- a/lib/html/scripts/systemhtml.py

+++ b/lib/html/scripts/systemhtml.py

@@ -66,7 +66,9 @@ def SecureOutputType(generator, type_name, is_dart_type=False):

dart_name = type_name

else:

dart_name = generator._DartType(type_name)

- if dart_name in _secure_base_types:

+ # We only need to secure Window. Only local History and Location are returned

+ # in generated code.

+ if dart_name == 'LocalWindow':

return _secure_base_types[dart_name]

return dart_name

« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »