Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1108583002: Revert of Lazily register prototype users (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow
Modified:
5 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Lazily register prototype users (patchset #2 id:20001 of https://codereview.chromium.org/1104813004/) Reason for revert: Suspected of causing GC stress failures. Original issue's description: > Lazily register prototype users > > when handing out validity cells to handles; because invalidating said cells is the only time we'll need the user registrations. > Along the way, fix a corner case in WeakFixedArray, which can now be empty after the recently introduced compaction support. > > Committed: https://crrev.com/a4bb7643c076b014816431a9b85af3e2edf828e7 > Cr-Commit-Position: refs/heads/master@{#28047} TBR=yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/968715c653b6337252a05a0224a7a93fab3b0866 Cr-Commit-Position: refs/heads/master@{#28049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -199 lines) Patch
M src/objects.h View 5 chunks +9 lines, -17 lines 0 comments Download
M src/objects.cc View 12 chunks +75 lines, -114 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D test/mjsunit/prototype-changes.js View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
Created Revert of Lazily register prototype users
5 years, 8 months ago (2015-04-24 14:09:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108583002/1
5 years, 8 months ago (2015-04-24 14:10:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 14:10:15 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 14:10:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/968715c653b6337252a05a0224a7a93fab3b0866
Cr-Commit-Position: refs/heads/master@{#28049}

Powered by Google App Engine
This is Rietveld 408576698