src/compiler/js-generic-lowering.cc - Issue 1108563002: Detect simple tail calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 1108563002: Detect simple tail calls (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Handle callers with args Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-generic-lowering.cc

diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc

index 3ebb6bc261fbec929fd2521e820a8779efb6af45..da2847e0f4386be2e1f790ba866c7cdc9dd81ad6 100644

--- a/src/compiler/js-generic-lowering.cc

+++ b/src/compiler/js-generic-lowering.cc

@@ -491,8 +491,10 @@ bool JSGenericLowering::TryLowerDirectJSCall(Node* node) {

context = jsgraph()->HeapConstant(Handle<Context>(function->context()));

}

node->ReplaceInput(index, context);

- CallDescriptor* desc = Linkage::GetJSCallDescriptor(

- zone(), false, 1 + arg_count, FlagsForNode(node));

+ CallDescriptor::Flags flags = FlagsForNode(node);

+ if (is_strict(p.language_mode())) flags |= CallDescriptor::kIsTailCallAllowed;

+ CallDescriptor* desc =

+ Linkage::GetJSCallDescriptor(zone(), false, 1 + arg_count, flags);

node->set_op(common()->Call(desc));

return true;

}