Enable support for QUIC 13.

Enable support for QUIC 13.

This does NOT cause Chrome to use QUIC 13, that will come later.
Refactors the mechanims that QUIC tests use to to create packets.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242130

[jar (doing other things), 2013-12-20 00:53:11]

LGTM % nits (and question about test method being called)

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_http_strea...
File net/quic/quic_http_stream_test.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_http_strea...
net/quic/quic_http_stream_test.cc:110: static const bool kIncludeFeedback =
true;
nit: kIncludeCongestionFeedback

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_http_strea...
net/quic/quic_http_stream_test.cc:227: response_data_ = GetParam() >
QUIC_VERSION_12 ? body :
nit: if might be nicer.

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_http_strea...
net/quic/quic_http_stream_test.cc:298: return (write_priority) ?
nit: with multi line, I'd prefer if()

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_http_strea...
net/quic/quic_http_stream_test.cc:377: // Regression test for
http://crbug.com/288128
nit: skip line

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_network_tr...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_network_tr...
net/quic/quic_network_transaction_unittest.cc:68: 
nit: delete line

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_reliable_c...
File net/quic/quic_reliable_client_stream_test.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_reliable_c...
net/quic/quic_reliable_client_stream_test.cc:41: public
::testing::TestWithParam<QuicVersion> {
nit: colon on line... etc.

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_stream_fac...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_stream_fac...
net/quic/quic_stream_factory.cc:260: QuicVersionVector supported_versions)
nit: const ref

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_stream_fac...
File net/quic/quic_stream_factory_test.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_stream_fac...
net/quic/quic_stream_factory_test.cc:190: TEST_P(QuicStreamFactoryTest,
FailedCreate) {
nuke since it comes later.

https://codereview.chromium.org/110853010/diff/40002/net/quic/test_tools/quic...
File net/quic/test_tools/quic_test_packet_maker.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/test_tools/quic...
net/quic/test_tools/quic_test_packet_maker.cc:176: DCHECK_LT(QUIC_VERSION_12,
version_);
Why is this here?  Is this called?

https://codereview.chromium.org/110853010/diff/40002/net/quic/test_tools/quic...
File net/quic/test_tools/quic_test_packet_maker.h (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/test_tools/quic...
net/quic/test_tools/quic_test_packet_maker.h:67: 
nit:  you mentioned newline here

https://codereview.chromium.org/110853010/diff/40002/net/quic/test_tools/quic...
net/quic/test_tools/quic_test_packet_maker.h:84: };
nit: DISALLOW_COPY...

[Ryan Hamilton, 2013-12-20 01:55:01]

Thanks!

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_http_strea...
File net/quic/quic_http_stream_test.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_http_strea...
net/quic/quic_http_stream_test.cc:110: static const bool kIncludeFeedback =
true;
On 2013/12/20 00:53:12, jar wrote:
> nit: kIncludeCongestionFeedback

Done.

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_http_strea...
net/quic/quic_http_stream_test.cc:227: response_data_ = GetParam() >
QUIC_VERSION_12 ? body :
On 2013/12/20 00:53:12, jar wrote:
> nit: if might be nicer.

Done.

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_http_strea...
net/quic/quic_http_stream_test.cc:298: return (write_priority) ?
On 2013/12/20 00:53:12, jar wrote:
> nit: with multi line, I'd prefer if()

Done.

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_http_strea...
net/quic/quic_http_stream_test.cc:377: // Regression test for
http://crbug.com/288128
On 2013/12/20 00:53:12, jar wrote:
> nit: skip line

Done.

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_network_tr...
File net/quic/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_network_tr...
net/quic/quic_network_transaction_unittest.cc:68: 
On 2013/12/20 00:53:12, jar wrote:
> nit: delete line

Done.

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_reliable_c...
File net/quic/quic_reliable_client_stream_test.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_reliable_c...
net/quic/quic_reliable_client_stream_test.cc:41: public
::testing::TestWithParam<QuicVersion> {
On 2013/12/20 00:53:12, jar wrote:
> nit: colon on line... etc.

Done.

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_stream_fac...
File net/quic/quic_stream_factory.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_stream_fac...
net/quic/quic_stream_factory.cc:260: QuicVersionVector supported_versions)
On 2013/12/20 00:53:12, jar wrote:
> nit: const ref

Done.

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_stream_fac...
File net/quic/quic_stream_factory_test.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/quic_stream_fac...
net/quic/quic_stream_factory_test.cc:190: TEST_P(QuicStreamFactoryTest,
FailedCreate) {
On 2013/12/20 00:53:12, jar wrote:
> nuke since it comes later.

Done.

https://codereview.chromium.org/110853010/diff/40002/net/quic/test_tools/quic...
File net/quic/test_tools/quic_test_packet_maker.cc (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/test_tools/quic...
net/quic/test_tools/quic_test_packet_maker.cc:176: DCHECK_LT(QUIC_VERSION_12,
version_);
On 2013/12/20 00:53:12, jar wrote:
> Why is this here?  Is this called?

Switched to GE.  I think I moved this around w/o running all the tests.  After
looking at your comments, I re-ran all QUIC tests, and this fired.  Fixing the
polarity did the right thing.

Nice catch.

https://codereview.chromium.org/110853010/diff/40002/net/quic/test_tools/quic...
File net/quic/test_tools/quic_test_packet_maker.h (right):

https://codereview.chromium.org/110853010/diff/40002/net/quic/test_tools/quic...
net/quic/test_tools/quic_test_packet_maker.h:67: 
On 2013/12/20 00:53:12, jar wrote:
> nit:  you mentioned newline here

Done.

https://codereview.chromium.org/110853010/diff/40002/net/quic/test_tools/quic...
net/quic/test_tools/quic_test_packet_maker.h:84: };
On 2013/12/20 00:53:12, jar wrote:
> nit: DISALLOW_COPY...

Done.

[commit-bot: I haz the power, 2013-12-20 03:27:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/110853010/90001

[commit-bot: I haz the power, 2013-12-20 08:02:29]

Retried try job too often on android_clang_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-12-20 16:33:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/110853010/110001

[commit-bot: I haz the power, 2013-12-20 19:00:24]

Change committed as 242130