Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: src/incremental-marking.cc

Issue 11085070: Enable --verify-heap in release mode (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More comment response, thx! Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-inl.h ('k') | src/mark-compact.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 EnsureMarkingDequeIsCommitted(); 554 EnsureMarkingDequeIsCommitted();
555 555
556 // Initialize marking stack. 556 // Initialize marking stack.
557 Address addr = static_cast<Address>(marking_deque_memory_->address()); 557 Address addr = static_cast<Address>(marking_deque_memory_->address());
558 size_t size = marking_deque_memory_->size(); 558 size_t size = marking_deque_memory_->size();
559 if (FLAG_force_marking_deque_overflows) size = 64 * kPointerSize; 559 if (FLAG_force_marking_deque_overflows) size = 64 * kPointerSize;
560 marking_deque_.Initialize(addr, addr + size); 560 marking_deque_.Initialize(addr, addr + size);
561 561
562 ActivateIncrementalWriteBarrier(); 562 ActivateIncrementalWriteBarrier();
563 563
564 #ifdef DEBUG
565 // Marking bits are cleared by the sweeper. 564 // Marking bits are cleared by the sweeper.
565 #ifdef VERIFY_HEAP
566 if (FLAG_verify_heap) { 566 if (FLAG_verify_heap) {
567 heap_->mark_compact_collector()->VerifyMarkbitsAreClean(); 567 heap_->mark_compact_collector()->VerifyMarkbitsAreClean();
568 } 568 }
569 #endif 569 #endif
570 570
571 heap_->CompletelyClearInstanceofCache(); 571 heap_->CompletelyClearInstanceofCache();
572 heap_->isolate()->compilation_cache()->MarkCompactPrologue(); 572 heap_->isolate()->compilation_cache()->MarkCompactPrologue();
573 573
574 if (FLAG_cleanup_code_caches_at_gc) { 574 if (FLAG_cleanup_code_caches_at_gc) {
575 // We will mark cache black with a separate pass 575 // We will mark cache black with a separate pass
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
951 bytes_scanned_ = 0; 951 bytes_scanned_ = 0;
952 write_barriers_invoked_since_last_step_ = 0; 952 write_barriers_invoked_since_last_step_ = 0;
953 } 953 }
954 954
955 955
956 int64_t IncrementalMarking::SpaceLeftInOldSpace() { 956 int64_t IncrementalMarking::SpaceLeftInOldSpace() {
957 return heap_->MaxOldGenerationSize() - heap_->PromotedSpaceSizeOfObjects(); 957 return heap_->MaxOldGenerationSize() - heap_->PromotedSpaceSizeOfObjects();
958 } 958 }
959 959
960 } } // namespace v8::internal 960 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap-inl.h ('k') | src/mark-compact.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698