Issue 11085045: Fix name of nexe in create_nmf post link step.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11085045: Fix name of nexe in create_nmf post link step. (Closed)

Created:
8 years, 2 months ago by Sam Clegg

Modified:
8 years, 2 months ago

Reviewers:
noelallen1, binji

CC:
native-client-reviews_googlegroups.com

Base URL:
http://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

Fix name of nexe in create_nmf post link step. Also, allow for spaces in project name or SDK location. BUG=153435 Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1439

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj	View		4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

binji

I have a question about the addin version though -- does this need to be ...

8 years, 2 months ago (2012-10-10 17:55:28 UTC) #3

Sam Clegg

8 years, 2 months ago (2012-10-10 17:58:18 UTC) #4

On 2012/10/10 17:55:28, binji wrote:
> I have a question about the addin version though -- does this need to be saved
> in the vcproj? It seems like something that will break if used on a team where
> the vcproj is checked in.

I guess that is an issue yes.  Tyler put it in there so that he
could detect old versions and make change to the project file.
Probably something that needs to be addressed...  I'll open a bug.

Expand Messages | Collapse Messages