Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2080)

Unified Diff: net/test/base_test_server.cc

Issue 11085039: WebSocket test server migration on browser_tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: retain std::string reference for GURL::Replacements Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/data/websocket/connect_check.html ('k') | net/tools/testserver/testserver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/test/base_test_server.cc
diff --git a/net/test/base_test_server.cc b/net/test/base_test_server.cc
index e672f19207355171bdd30a2fe7e8ce98c8560213..461714c2f867dd126997cea97e86b37d5aed07c0 100644
--- a/net/test/base_test_server.cc
+++ b/net/test/base_test_server.cc
@@ -339,9 +339,7 @@ bool BaseTestServer::GenerateArguments(base::DictionaryValue* arguments) const {
if (VLOG_IS_ON(1) || log_to_console_)
arguments->Set("log-to-console", base::Value::CreateNullValue());
- if (type_ == TYPE_HTTPS) {
- arguments->Set("https", base::Value::CreateNullValue());
-
+ if (UsingSSL(type_)) {
// Check the certificate arguments of the HTTPS server.
FilePath certificate_path(certificates_dir_);
FilePath certificate_file(ssl_options_.GetCertificateFile());
@@ -355,6 +353,11 @@ bool BaseTestServer::GenerateArguments(base::DictionaryValue* arguments) const {
}
arguments->SetString("cert-and-key-file", certificate_path.value());
}
+ }
+
+ if (type_ == TYPE_HTTPS) {
+ // TODO(toyoshim): TYPE_WSS should support client auth, too.
Ryan Sleevi 2012/10/15 16:51:54 Do you have a BUG # to track this?
+ arguments->Set("https", base::Value::CreateNullValue());
std::string ocsp_arg = ssl_options_.GetOCSPArgument();
if (!ocsp_arg.empty())
« no previous file with comments | « net/data/websocket/connect_check.html ('k') | net/tools/testserver/testserver.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698