Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: sdk/lib/core/string.dart

Issue 11085003: Convert String to a class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Merged to tip of bleeding_edge. Updated test expecteation Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/core_patch.dart ('k') | sdk/lib/core/string_buffer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/core/string.dart
diff --git a/sdk/lib/core/string.dart b/sdk/lib/core/string.dart
index ad4aefee7e1fca8b4e591dd6fed3f8de54c22e9d..f2d0e613203d238145d68ef8416cddb30d6c79b6 100644
--- a/sdk/lib/core/string.dart
+++ b/sdk/lib/core/string.dart
@@ -8,13 +8,11 @@
* scalar character codes accessible through the [charCodeAt] or the
* [charCodes] method.
*/
-interface String
- extends Comparable, Pattern, Sequence<String>
- default _StringImpl {
+abstract class String implements Comparable, Pattern, Sequence<String> {
/**
* Allocates a new String for the specified [charCodes].
*/
- String.fromCharCodes(List<int> charCodes);
+ external factory String.fromCharCodes(List<int> charCodes);
/**
* Gets the character (as [String]) at the given [index].
@@ -131,22 +129,3 @@ interface String
*/
String toUpperCase();
}
-
-class _StringImpl {
- /**
- * Factory implementation of String.fromCharCodes:
- * Allocates a new String for the specified [charCodes].
- */
- external factory String.fromCharCodes(List<int> charCodes);
-
- /**
- * Joins all the given strings to create a new string.
- */
- external static String join(List<String> strings, String separator);
-
- /**
- * Concatenates all the given strings to create a new string.
- */
- external static String concatAll(List<String> strings);
-
-}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/core_patch.dart ('k') | sdk/lib/core/string_buffer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698