Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 11085003: Convert String to a class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 __ jmp(is_not_instance_lbl); 254 __ jmp(is_not_instance_lbl);
255 return false; 255 return false;
256 } 256 }
257 // Custom checking for numbers (Smi, Mint, Bigint and Double). 257 // Custom checking for numbers (Smi, Mint, Bigint and Double).
258 // Note that instance is not Smi (checked above). 258 // Note that instance is not Smi (checked above).
259 if (type.IsSubtypeOf(Type::Handle(Type::Number()), NULL)) { 259 if (type.IsSubtypeOf(Type::Handle(Type::Number()), NULL)) {
260 GenerateNumberTypeCheck( 260 GenerateNumberTypeCheck(
261 kClassIdReg, type, is_instance_lbl, is_not_instance_lbl); 261 kClassIdReg, type, is_instance_lbl, is_not_instance_lbl);
262 return false; 262 return false;
263 } 263 }
264 if (type.IsStringInterface()) { 264 if (type.IsStringType()) {
265 GenerateStringTypeCheck(kClassIdReg, is_instance_lbl, is_not_instance_lbl); 265 GenerateStringTypeCheck(kClassIdReg, is_instance_lbl, is_not_instance_lbl);
266 return false; 266 return false;
267 } 267 }
268 // Otherwise fallthrough. 268 // Otherwise fallthrough.
269 return true; 269 return true;
270 } 270 }
271 271
272 272
273 // Uses SubtypeTestCache to store instance class and result. 273 // Uses SubtypeTestCache to store instance class and result.
274 // EAX: instance to test. 274 // EAX: instance to test.
(...skipping 1106 matching lines...) Expand 10 before | Expand all | Expand 10 after
1381 __ popl(ECX); 1381 __ popl(ECX);
1382 __ popl(EAX); 1382 __ popl(EAX);
1383 } 1383 }
1384 1384
1385 1385
1386 #undef __ 1386 #undef __
1387 1387
1388 } // namespace dart 1388 } // namespace dart
1389 1389
1390 #endif // defined TARGET_ARCH_IA32 1390 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698