Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1108463002: Revert of ui: Cache the output of View::OnPaint when the View isn't invalid. (Closed)

Created:
5 years, 8 months ago by Justin Donnelly
Modified:
5 years, 8 months ago
Reviewers:
danakj, sky, piman
CC:
chromium-reviews, tdanderson+views_chromium.org, Ian Vollick, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, enne (OOO), piman, sadrul, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ui: Cache the output of View::OnPaint when the View isn't invalid. (patchset #4 id:80001 of https://codereview.chromium.org/1101783002/) Reason for revert: ash_unittests are timing out on Win8 Aura and Linux ChromiumOS Tests (dbg)(1) bots. Reverting this CL in order to revert https://codereview.chromium.org/1080633009/ which we suspect to be the cause of the problem. Original issue's description: > ui: Cache the output of View::OnPaint when the View isn't invalid. > > Store the output of View::OnPaint as a PaintCache object, and when the > view has not been invalidated, use that cache output instead of doing > work to build a recording. > > Performance data as follows when the loading spinner is going: > > Before impl-side (TOT): 0.13ms / paint > With impl-side (no slimming paint): 0.22ms / paint > With impl-side and slimming paint (this patch): 0.17ms / paint > > So this gets us some of the way there. I need to investigate why it's > not doing more. > > R=piman@chromium.org, sky > BUG=466426 > > Committed: https://crrev.com/7f686cdcff81d6779b962e98e529a7360be2809c > Cr-Commit-Position: refs/heads/master@{#326592} TBR=piman@chromium.org,sky@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466426 Committed: https://crrev.com/f2f043dcd893c280bbf8a2da9abf87c7abb50460 Cr-Commit-Position: refs/heads/master@{#326636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -135 lines) Patch
M cc/resources/drawing_display_item.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/drawing_display_item.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/layer.cc View 1 chunk +5 lines, -4 lines 0 comments Download
D ui/compositor/paint_cache.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/compositor/paint_cache.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M ui/compositor/paint_context.h View 2 chunks +4 lines, -12 lines 0 comments Download
M ui/compositor/paint_recorder.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ui/compositor/paint_recorder.cc View 2 chunks +6 lines, -15 lines 0 comments Download
M ui/views/view.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/views/view.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Donnelly
Created Revert of ui: Cache the output of View::OnPaint when the View isn't invalid.
5 years, 8 months ago (2015-04-23 20:50:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108463002/1
5 years, 8 months ago (2015-04-23 20:51:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 20:53:01 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 20:53:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2f043dcd893c280bbf8a2da9abf87c7abb50460
Cr-Commit-Position: refs/heads/master@{#326636}

Powered by Google App Engine
This is Rietveld 408576698