Source/core/html/parser/HTMLParserIdioms.cpp - Issue 110843004: Replaced HTMLIdentifier with an atomized string factory function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/HTMLParserIdioms.cpp

Issue 110843004: Replaced HTMLIdentifier with an atomized string factory function (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/parser/HTMLIdentifier.cpp ('K') | « Source/core/html/parser/HTMLParserIdioms.h ('k') | Source/core/html/parser/HTMLPreloadScanner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/parser/HTMLParserIdioms.cpp

diff --git a/Source/core/html/parser/HTMLParserIdioms.cpp b/Source/core/html/parser/HTMLParserIdioms.cpp

index 2173ef531261f3be7ebcc273d7cee35f4005d787..d94e299129a3a63242f951018709d9aee3dfc24a 100644

--- a/Source/core/html/parser/HTMLParserIdioms.cpp

+++ b/Source/core/html/parser/HTMLParserIdioms.cpp

@@ -278,9 +278,9 @@ bool threadSafeMatch(const QualifiedName& a, const QualifiedName& b)

return threadSafeEqual(a.localName().impl(), b.localName().impl());

}

-bool threadSafeMatch(const HTMLIdentifier& localName, const QualifiedName& qName)

+bool threadSafeMatch(const String& localName, const QualifiedName& qName)

{

- return threadSafeEqual(localName.asStringImpl(), qName.localName().impl());

+ return threadSafeEqual(localName.impl(), qName.localName().impl());

}

« Source/core/html/parser/HTMLIdentifier.cpp ('K') | « Source/core/html/parser/HTMLParserIdioms.h ('k') | Source/core/html/parser/HTMLPreloadScanner.cpp » ('j') | no next file with comments »