Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: Source/core/html/parser/CompactHTMLToken.h

Issue 110843004: Replaced HTMLIdentifier with an atomized string factory function (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review fixes Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2013 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY GOOGLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL GOOGLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL GOOGLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef CompactHTMLToken_h 26 #ifndef CompactHTMLToken_h
27 #define CompactHTMLToken_h 27 #define CompactHTMLToken_h
28 28
29 #include "core/html/parser/HTMLIdentifier.h"
30 #include "core/html/parser/HTMLToken.h" 29 #include "core/html/parser/HTMLToken.h"
31 #include "wtf/Vector.h" 30 #include "wtf/Vector.h"
32 #include "wtf/text/TextPosition.h" 31 #include "wtf/text/TextPosition.h"
33 #include "wtf/text/WTFString.h" 32 #include "wtf/text/WTFString.h"
34 33
35 namespace WebCore { 34 namespace WebCore {
36 35
37 class QualifiedName; 36 class QualifiedName;
38 37
39 class CompactHTMLToken { 38 class CompactHTMLToken {
40 public: 39 public:
41 struct Attribute { 40 struct Attribute {
42 Attribute(const HTMLIdentifier& name, const String& value) 41 Attribute(const String& name, const String& value)
43 : name(name) 42 : name(name)
44 , value(value) 43 , value(value)
45 { 44 {
46 } 45 }
47 46
48 HTMLIdentifier name; 47 String name;
49 String value; 48 String value;
50 }; 49 };
51 50
52 CompactHTMLToken(const HTMLToken*, const TextPosition&); 51 CompactHTMLToken(const HTMLToken*, const TextPosition&);
53 52
54 bool isSafeToSendToAnotherThread() const; 53 bool isSafeToSendToAnotherThread() const;
55 54
56 HTMLToken::Type type() const { return static_cast<HTMLToken::Type>(m_type); } 55 HTMLToken::Type type() const { return static_cast<HTMLToken::Type>(m_type); }
57 const HTMLIdentifier& data() const { return m_data; } 56 const String& data() const { return m_data; }
58 bool selfClosing() const { return m_selfClosing; } 57 bool selfClosing() const { return m_selfClosing; }
59 bool isAll8BitData() const { return m_isAll8BitData; } 58 bool isAll8BitData() const { return m_isAll8BitData; }
60 const Vector<Attribute>& attributes() const { return m_attributes; } 59 const Vector<Attribute>& attributes() const { return m_attributes; }
61 const Attribute* getAttributeItem(const QualifiedName&) const; 60 const Attribute* getAttributeItem(const QualifiedName&) const;
62 const TextPosition& textPosition() const { return m_textPosition; } 61 const TextPosition& textPosition() const { return m_textPosition; }
63 62
64 // There is only 1 DOCTYPE token per document, so to avoid increasing the 63 // There is only 1 DOCTYPE token per document, so to avoid increasing the
65 // size of CompactHTMLToken, we just use the m_attributes vector. 64 // size of CompactHTMLToken, we just use the m_attributes vector.
66 const HTMLIdentifier& publicIdentifier() const { return m_attributes[0].name ; } 65 const String& publicIdentifier() const { return m_attributes[0].name; }
67 const String& systemIdentifier() const { return m_attributes[0].value; } 66 const String& systemIdentifier() const { return m_attributes[0].value; }
68 bool doctypeForcesQuirks() const { return m_doctypeForcesQuirks; } 67 bool doctypeForcesQuirks() const { return m_doctypeForcesQuirks; }
69 68
70 private: 69 private:
71 unsigned m_type : 4; 70 unsigned m_type : 4;
72 unsigned m_selfClosing : 1; 71 unsigned m_selfClosing : 1;
73 unsigned m_isAll8BitData : 1; 72 unsigned m_isAll8BitData : 1;
74 unsigned m_doctypeForcesQuirks: 1; 73 unsigned m_doctypeForcesQuirks: 1;
75 74
76 HTMLIdentifier m_data; // "name", "characters", or "data" depending on m_typ e 75 String m_data; // "name", "characters", or "data" depending on m_type
77 Vector<Attribute> m_attributes; 76 Vector<Attribute> m_attributes;
78 TextPosition m_textPosition; 77 TextPosition m_textPosition;
79 }; 78 };
80 79
81 typedef Vector<CompactHTMLToken> CompactHTMLTokenStream; 80 typedef Vector<CompactHTMLToken> CompactHTMLTokenStream;
82 81
83 } 82 }
84 83
85 #endif 84 #endif
OLDNEW
« no previous file with comments | « Source/core/html/parser/CSSPreloadScanner.cpp ('k') | Source/core/html/parser/CompactHTMLToken.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698