Replaced HTMLIdentifier with an atomized string factory function

Source/core/html/parser/HTMLIdentifier.h

 /*
  * Copyright (C) 2013 Google, Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 22 matching lines @@
 class QualifiedName;
 
 enum CharacterWidth {
     Likely8Bit,
     Force8Bit,
     Force16Bit
 };
 
 class HTMLIdentifier {
 public:
-    HTMLIdentifier() { }
 
     template<size_t inlineCapacity>
-    HTMLIdentifier(const Vector<UChar, inlineCapacity>& vector, CharacterWidth width)
-        : m_string(findIfKnown(vector.data(), vector.size()))
+    static String create(const Vector<UChar, inlineCapacity>& vector, CharacterWidth width)
     {
-        if (m_string.impl())
-            return;
+        String string(findIfKnown(vector.data(), vector.size()));
+        if (string.impl())
+            return string;
         if (width == Likely8Bit)
-            m_string = StringImpl::create8BitIfPossible(vector);
+            string = StringImpl::create8BitIfPossible(vector);
         else if (width == Force8Bit)
-            m_string = String::make8BitFrom16BitSource(vector);
+            string = String::make8BitFrom16BitSource(vector);
         else
-            m_string = String(vector);
+            string = String(vector);
+
+        return string;
     }

[abarth-chromium, 2013/12/10 01:22:52]

It seems like we don't need this class anymore.  We can just make this a free
function in HTMLParserIdioms.

 
-    // asString should only be used on the main thread.
-    const String& asString() const;
-    // asStringImpl() is safe to call from any thread.
-    const StringImpl* asStringImpl() const;
-
     static void init();
 
-    bool isSafeToSendToAnotherThread() const { return m_string.isSafeToSendToAnotherThread(); }
-
-#ifndef NDEBUG
-    static bool isKnown(const StringImpl*);
-#endif
 
 private:
     static unsigned maxNameLength;
     static StringImpl* findIfKnown(const UChar* characters, unsigned length);
     static void addNames(const QualifiedName* const* names, unsigned namesCount);
 
     String m_string;

[abarth-chromium, 2013/12/10 01:22:52]

Is this member used anywhere?

 };
 
 }
 
 #endif