Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 110843003: Clean up mojo export files. (Closed)

Created:
7 years ago by tfarina
Modified:
7 years ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Clean up mojo export files. While I was looking at these files I noticed the GFX_IMPLEMENTATION, which triggered me to make these cleanups. BUG=None TEST=None TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240009

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fixes #

Patch Set 4 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M mojo/common/mojo_common_export.h View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/gles2/gles2.h View 1 2 3 2 chunks +10 lines, -7 lines 0 comments Download
M mojo/public/system/system_export.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
TBRing...
7 years ago (2013-12-09 23:38:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/110843003/1
7 years ago (2013-12-09 23:42:43 UTC) #2
commit-bot: I haz the power
Failed to apply patch for mojo/public/gles2/gles2.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-10 07:56:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/110843003/60001
7 years ago (2013-12-11 00:53:36 UTC) #4
commit-bot: I haz the power
Change committed as 240009
7 years ago (2013-12-11 04:25:17 UTC) #5
darin (slow to review)
7 years ago (2013-12-11 05:30:33 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698