Issue 1108413003: Check for *.googlezip.net proxies when migrating proxy pref for DRP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1108413003: Check for *.googlezip.net proxies when migrating proxy pref for DRP. (Closed)

Created:
5 years, 7 months ago by sclittle

Modified:
5 years, 7 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2357

Target Ref:
refs/pending/branch-heads/2357

Project:
chromium

Visibility:
Public.

More Reviews

Description

Check for *.googlezip.net proxies when migrating proxy pref for DRP. Previously, the proxy pref would not be cleared during migration if the proxy pref was set to a Data Reduction Proxy that didn't match a currently configured DRP, e.g. if the pref was for "proxy.googlezip.net", but the configured DRP is "proxy-dev.googlezip.net". This change causes Chrome to clear the proxy pref if it contains any proxy with a host ending with ".googlezip.net". BUG=476610 Review URL: https://codereview.chromium.org/1104413003 Cr-Commit-Position: refs/heads/master@{#327357} (cherry picked from commit 8f9fd102faa07d91dbe680f160f9ea0057e4eb5f) Committed: https://chromium.googlesource.com/chromium/src/+/2b83a8a8e0ee2dd7ed5aa8d3f60b06c5713d1c1f

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -28 lines)			Patch
	M	chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc	View		3 chunks	+42 lines, -1 line	0 comments	Download
	M	chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc	View		1 chunk	+70 lines, -27 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

sclittle

5 years, 7 months ago (2015-04-29 22:15:08 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2b83a8a8e0ee2dd7ed5aa8d3f60b06c5713d1c1f.

Expand Messages | Collapse Messages