Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1108403008: Adds resource_provider::ResourceProvider (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds resource_provider::ResourceProvider It's used to fetch resources for mojo apps. R=ben@chromium.org Committed: https://crrev.com/6de67f80026697580ed4cefa11a72193243bd4a0 Cr-Commit-Position: refs/heads/master@{#328014} Committed: https://crrev.com/63795badcd1a2ba1a37605540bbbb12465d908ec Cr-Commit-Position: refs/heads/master@{#328064}

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge 2 trunk #

Patch Set 3 : no-find-copies #

Patch Set 4 : merge to trunk #

Patch Set 5 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+637 lines, -10 lines) Patch
A components/resource_provider/BUILD.gn View 1 1 chunk +83 lines, -0 lines 0 comments Download
A + components/resource_provider/DEPS View 1 3 1 chunk +1 line, -0 lines 0 comments Download
A + components/resource_provider/OWNERS View 1 3 0 chunks +-1 lines, --1 lines 0 comments Download
A components/resource_provider/file_utils.h View 1 chunk +29 lines, -0 lines 0 comments Download
A components/resource_provider/file_utils.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A components/resource_provider/file_utils_unittest.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A + components/resource_provider/main.cc View 3 1 chunk +2 lines, -2 lines 0 comments Download
A + components/resource_provider/public/interfaces/BUILD.gn View 3 1 chunk +3 lines, -1 line 0 comments Download
A components/resource_provider/public/interfaces/resource_provider.mojom View 1 1 chunk +18 lines, -0 lines 0 comments Download
A components/resource_provider/resource_provider_app.h View 1 chunk +46 lines, -0 lines 0 comments Download
A components/resource_provider/resource_provider_app.cc View 1 1 chunk +45 lines, -0 lines 0 comments Download
A components/resource_provider/resource_provider_apptest.cc View 1 1 chunk +146 lines, -0 lines 0 comments Download
A components/resource_provider/resource_provider_impl.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A components/resource_provider/resource_provider_impl.cc View 1 1 chunk +60 lines, -0 lines 0 comments Download
A components/test/data/resource_provider/dir/sample2 View 1 chunk +1 line, -0 lines 0 comments Download
A components/test/data/resource_provider/sample View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/mojo_application_package.gni View 2 chunks +11 lines, -8 lines 0 comments Download
M mojo/services/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/tools/data/apptests View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (3 generated)
sky
5 years, 7 months ago (2015-04-29 23:54:46 UTC) #1
sky
I realized reading the data and passing that around, while useful in some situations, isn't ...
5 years, 7 months ago (2015-05-01 15:25:25 UTC) #2
Ben Goodger (Google)
I will look at this when I get in. On Fri, May 1, 2015 at ...
5 years, 7 months ago (2015-05-01 15:34:56 UTC) #3
sky
You can hold off for now as I need to sort out access to platform ...
5 years, 7 months ago (2015-05-01 15:40:16 UTC) #4
Ben Goodger (Google)
https://codereview.chromium.org/1108403008/diff/1/components/resource_provider/public/interfaces/resource_provider.mojom File components/resource_provider/public/interfaces/resource_provider.mojom (right): https://codereview.chromium.org/1108403008/diff/1/components/resource_provider/public/interfaces/resource_provider.mojom#newcode12 components/resource_provider/public/interfaces/resource_provider.mojom:12: // must be relative, eg no leading '/'. You ...
5 years, 7 months ago (2015-05-01 17:19:07 UTC) #5
sky
I've updated the patch to pass around platform handles as well as to take a ...
5 years, 7 months ago (2015-05-01 20:35:15 UTC) #6
Ben Goodger (Google)
lgtm
5 years, 7 months ago (2015-05-01 21:20:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108403008/40001
5 years, 7 months ago (2015-05-01 22:23:20 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-01 23:21:58 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6de67f80026697580ed4cefa11a72193243bd4a0 Cr-Commit-Position: refs/heads/master@{#328014}
5 years, 7 months ago (2015-05-01 23:23:43 UTC) #11
Dan Beam
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1113223003/ by dbeam@chromium.org. ...
5 years, 7 months ago (2015-05-01 23:44:48 UTC) #12
sky
This was reverted because of accidental change here: https://codereview.chromium.org/1108403008/diff/60001/mandoline/app/desktop/launcher_process.cc . I've fixed that and am ...
5 years, 7 months ago (2015-05-02 15:36:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108403008/80001
5 years, 7 months ago (2015-05-02 15:36:57 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-02 16:29:13 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-02 16:30:03 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/63795badcd1a2ba1a37605540bbbb12465d908ec
Cr-Commit-Position: refs/heads/master@{#328064}

Powered by Google App Engine
This is Rietveld 408576698