Add batch unit tests for ovals

Add batch unit tests for ovals

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/3e708c53f79a04b588b6ca8e535e61f986d80b47

[joshualitt, 2015-04-29 20:10:08]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[joshualitt, 2015-04-29 20:10:09]

I don't think I'm covering every case here with RRects, but its a start.  I will
fix the bounds nastiness when this is all done.

[robertphillips, 2015-04-30 14:07:32]

lgtm + nits

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrOvalRenderer.cpp
File src/gpu/GrOvalRenderer.cpp (right):

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:920: 
bounds->setLTRB(... ?
also, just 2 lines  ?

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:1218: 
same

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:1245: const SkStrokeRec& stroke) {
Should this assert go in create_ellipse_batch ?

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:1519: 
same

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:2108: GrGpu* gpu) {
SkASSERT(viewMatrix.rectStaysRect());
SkASSERT(rrect.isSimple());
SkASSERT(!rrect.isOval());
+ maybe:
// RRect batchs only handle simple, but not too simple, rrects ...

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrOvalRenderer....
src/gpu/GrOvalRenderer.cpp:2301: bool strokeAndFill = random->nextBool();
Should probably also have a very wide stroke - 10.0f ?

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrTestUtils.cpp
File src/gpu/GrTestUtils.cpp (right):

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrTestUtils.cpp...
src/gpu/GrTestUtils.cpp:75: gMatrices[5].setRotate(90);
Move this up to first line in the if-block?

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrTestUtils.cpp...
src/gpu/GrTestUtils.cpp:110: // true round rect
// true round rect with circular corners

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrTestUtils.cpp...
src/gpu/GrTestUtils.cpp:111: gRRect[2].setRectXY(rectangle, 1.f, 1.f);
same here ?

https://codereview.chromium.org/1108403005/diff/40001/src/gpu/GrTestUtils.cpp...
src/gpu/GrTestUtils.cpp:111: gRRect[2].setRectXY(rectangle, 1.f, 1.f);
// true round rect with elliptical corners
gRRect[3].setRectXY(rectanble, 2.0f, 1.0f);
?

[joshualitt, 2015-04-30 20:37:23]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-04-30 20:37:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1108403005/#ps80001
(title: "tweaks")

[commit-bot: I haz the power, 2015-04-30 20:37:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108403005/80001

[commit-bot: I haz the power, 2015-04-30 20:38:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 20:38:05]

Presubmit check for 1108403005-80001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[joshualitt, 2015-04-30 20:39:12]

Brian, can you rubberstamp this?

[bsalomon, 2015-04-30 20:43:57]

lgtm

[joshualitt, 2015-04-30 20:45:37]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-04-30 20:46:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108403005/80001

[commit-bot: I haz the power, 2015-04-30 20:49:32]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/3e708c53f79a04b588b6ca8e535e61f986d80b47

[brucedawson, 2015-05-04 17:10:53]

It would be nice if the CL description had acknowledged that this also fixed the
sizes of a couple of arrays in order to avoid out-of-range accesses. The
description feels incomplete as-is.