Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1108373003: Add ios/web/ test data for PNG favicon (Closed)

Created:
5 years, 7 months ago by stuartmorgan
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ios/web/ test data for PNG favicon This will be used by the next portion of ios/web/ code being upstreamed; separating into another CL since it contains a binary file. BUG=464810 R=eugenebut@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f006fd0f9964860109f2faf0d3c5a5b8606bd435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/web/ios_web_unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ios/web/test/data/testfavicon.png View Binary file 0 comments Download

Messages

Total messages: 5 (1 generated)
stuartmorgan
5 years, 7 months ago (2015-04-28 18:07:01 UTC) #2
Eugene But (OOO till 7-30)
lgtm
5 years, 7 months ago (2015-04-28 18:08:52 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f006fd0f9964860109f2faf0d3c5a5b8606bd435 Cr-Commit-Position: refs/heads/master@{#327329}
5 years, 7 months ago (2015-04-28 18:18:07 UTC) #4
stuartmorgan
5 years, 7 months ago (2015-04-28 18:18:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f006fd0f9964860109f2faf0d3c5a5b8606bd435 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698