Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1108373002: Fix JSArrayBuffer for big endian. (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix JSArrayBuffer for big endian. BUG= R=jochen@chromium.org, dcarney@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com Committed: https://crrev.com/f76fd06d11b9da091af920a240875826fc5ab52c Cr-Commit-Position: refs/heads/master@{#28118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M src/objects.h View 1 chunk +7 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
MTBrandyberry
Please TAL. This follows the example of Name::kHashFieldOffset for endian-neutral accessors.
5 years, 7 months ago (2015-04-28 16:26:59 UTC) #1
dstence
On 2015/04/28 16:26:59, mtbrandyberry wrote: > Please TAL. This follows the example of Name::kHashFieldOffset for ...
5 years, 7 months ago (2015-04-28 16:56:31 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-28 19:02:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108373002/1
5 years, 7 months ago (2015-04-28 19:16:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 20:00:49 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 20:01:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f76fd06d11b9da091af920a240875826fc5ab52c
Cr-Commit-Position: refs/heads/master@{#28118}

Powered by Google App Engine
This is Rietveld 408576698