Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1108323002: Rename exclusion for WinHeapDumpProviderTest.DumpInto -> OnMemoryDump (Closed)

Created:
5 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename exclusion for WinHeapDumpProviderTest.DumpInto -> OnMemoryDump crrev.com/1107093004 performed a mass-rename of the MemoryDumpProvider.DumpInto() method, but forgot to rename the exclusion rule. BUG=481231 TBR=bruening@chromium.org,sebmarchand@chromium.org Committed: https://crrev.com/da28088c3299f13c82cd3647a7495a29354df749 Cr-Commit-Position: refs/heads/master@{#327282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/valgrind/gtest_exclude/base_unittests.gtest-drmemory_win32.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108323002/1
5 years, 7 months ago (2015-04-28 14:17:24 UTC) #2
Sébastien Marchand
lgtm
5 years, 7 months ago (2015-04-28 14:19:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 14:30:09 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 14:31:03 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da28088c3299f13c82cd3647a7495a29354df749
Cr-Commit-Position: refs/heads/master@{#327282}

Powered by Google App Engine
This is Rietveld 408576698