Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 1108313003: Add HArrayBufferNotNeutered instruction (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add HArrayBufferNotNeutered instruction This instruction can be hoisted out of loops even though it contains a branch. BUG=v8:3996 R=bmeurer@chromium.org LOG=n Committed: https://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355 Cr-Commit-Position: refs/heads/master@{#28109}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+359 lines, -27 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/arm64/lithium-arm64.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +4 lines, -27 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +31 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M src/mips64/lithium-mips64.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/ppc/lithium-ppc.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +16 lines, -0 lines 1 comment Download
M src/x64/lithium-x64.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M src/x87/lithium-x87.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcarney
lgtm
5 years, 7 months ago (2015-04-28 13:02:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1108313003/60001
5 years, 7 months ago (2015-04-28 13:40:59 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-04-28 13:43:01 UTC) #5
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/a2e6f970c766c4e197a20eb7badd251757249355 Cr-Commit-Position: refs/heads/master@{#28109}
5 years, 7 months ago (2015-04-28 13:43:10 UTC) #6
Sven Panne
5 years, 7 months ago (2015-04-28 13:45:16 UTC) #8
Message was sent while issue was closed.
Late DBC...

https://codereview.chromium.org/1108313003/diff/60001/src/x64/lithium-codegen...
File src/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/1108313003/diff/60001/src/x64/lithium-codegen...
src/x64/lithium-codegen-x64.cc:5174: DeoptimizeIf(not_zero, instr,
Deoptimizer::kOutOfBounds);
Would it be worth introducing a new deopt message instead of kOutOfBounds? As it
is, things might be confusing for users...

Powered by Google App Engine
This is Rietveld 408576698