HTMLPreloadScanner unit tests

HTMLPreloadScanner unit tests

This CL refactors the HTMLPreloadScanner and neighbouring classes in order to enable to write unit tests for the preloader.
It does not include any meaningful testing, which will be added at later CLs.

BUG=471249
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194746

[Yoav Weiss, 2015-04-28 13:27:43]

yoav@yoav.ws changed reviewers:
+ mkwst@chromium.org

[Yoav Weiss, 2015-04-28 13:28:58]

Hey Mike,

Here's another CL that enables us to test the preload scanner in a saner way
than what we do today with layout tests.
Let me know if you have time to review it :)

[Mike West, 2015-04-28 14:46:04]

I'm in back-to-back-to-back meetings for the next ~3 days... I'll certainly be
taking a look at codereview from time to time, but I'm not a reliable reviewer
at the moment.

I'd suggest CCing some other folks. If I get to it before they do, great!
Otherwise, you'll have a chance of someone looking at it before Friday. :)

[Yoav Weiss, 2015-04-28 14:47:56]

yoav@yoav.ws changed reviewers:
+ japhet@chromium.org, kouhei@chromium.org

[Yoav Weiss, 2015-04-29 10:22:21]

yoav@yoav.ws changed reviewers:
+ pmeenan@google.com

[kouhei (in TOK), 2015-04-30 12:59:21]

Thanks for working on this. Preloader was known for number of bugs, and
hopefully we can write tests using this infra now :)

https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
File Source/core/html/parser/HTMLPreloadScannerTest.cpp (right):

https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
Source/core/html/parser/HTMLPreloadScannerTest.cpp:92:
PassOwnPtr<HTMLPreloadScanner> createHTMLPreloadScanner(const HTMLParserOptions&
options, const KURL& documentURL, PassRefPtr<MediaValues> mediaValues)
Move this as HTMLPreloadScanner::create

https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
File Source/core/html/parser/HTMLResourcePreloader.cpp (right):

https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
Source/core/html/parser/HTMLResourcePreloader.cpp:51: void
HTMLResourcePreloader::takeAndPreload(PreloadRequestStream& r)
Remove this. This implementation seems idential to
ResourcePreloader::takeAndPreload.

https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
File Source/core/html/parser/HTMLResourcePreloader.h (right):

https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
Source/core/html/parser/HTMLResourcePreloader.h:44: virtual void
takeAndPreload(PreloadRequestStream&);
remove this?

https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
Source/core/html/parser/HTMLResourcePreloader.h:47: virtual void
preload(PassOwnPtr<PreloadRequest>);
override

https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
File Source/core/html/parser/ResourcePreloader.h (right):

https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
Source/core/html/parser/ResourcePreloader.h:15: protected:
This can be private

[Yoav Weiss, 2015-04-30 13:18:17]

On 2015/04/30 12:59:21, kouhei wrote:
> Thanks for working on this. Preloader was known for number of bugs, and
> hopefully we can write tests using this infra now :)
> 
>
https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
> File Source/core/html/parser/HTMLPreloadScannerTest.cpp (right):
> 
>
https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
> Source/core/html/parser/HTMLPreloadScannerTest.cpp:92:
> PassOwnPtr<HTMLPreloadScanner> createHTMLPreloadScanner(const
HTMLParserOptions&
> options, const KURL& documentURL, PassRefPtr<MediaValues> mediaValues)
> Move this as HTMLPreloadScanner::create
> 
>
https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
> File Source/core/html/parser/HTMLResourcePreloader.cpp (right):
> 
>
https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
> Source/core/html/parser/HTMLResourcePreloader.cpp:51: void
> HTMLResourcePreloader::takeAndPreload(PreloadRequestStream& r)
> Remove this. This implementation seems idential to
> ResourcePreloader::takeAndPreload.
> 
>
https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
> File Source/core/html/parser/HTMLResourcePreloader.h (right):
> 
>
https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
> Source/core/html/parser/HTMLResourcePreloader.h:44: virtual void
> takeAndPreload(PreloadRequestStream&);
> remove this?
> 
>
https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
> Source/core/html/parser/HTMLResourcePreloader.h:47: virtual void
> preload(PassOwnPtr<PreloadRequest>);
> override
> 
>
https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
> File Source/core/html/parser/ResourcePreloader.h (right):
> 
>
https://codereview.chromium.org/1108303002/diff/20001/Source/core/html/parser...
> Source/core/html/parser/ResourcePreloader.h:15: protected:
> This can be private

Thanks for reviewing :) Done.

[kouhei (in TOK), 2015-04-30 14:06:29]

lgtm

https://codereview.chromium.org/1108303002/diff/40001/Source/core/html/parser...
File Source/core/html/parser/HTMLPreloadScanner.h (right):

https://codereview.chromium.org/1108303002/diff/40001/Source/core/html/parser...
Source/core/html/parser/HTMLPreloadScanner.h:110: static
PassOwnPtr<HTMLPreloadScanner> create(const HTMLParserOptions&, const KURL&
documentURL, PassRefPtr<MediaValues>);
Nit: inline

[Yoav Weiss, 2015-04-30 14:54:12]

The CQ bit was checked by yoav@yoav.ws

[Yoav Weiss, 2015-04-30 14:54:13]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/1108303002/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2015-04-30 14:54:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1108303002/60001

[commit-bot: I haz the power, 2015-04-30 15:47:41]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194746