Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2696)

Unified Diff: cc/CCDelegatedRendererLayerImplTest.cpp

Issue 11083003: Revert 160631 - [cc] Store CCLayerImpls as scoped_ptrs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/CCDelegatedRendererLayerImpl.h ('k') | cc/CCHeadsUpDisplayLayerImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/CCDelegatedRendererLayerImplTest.cpp
===================================================================
--- cc/CCDelegatedRendererLayerImplTest.cpp (revision 160631)
+++ cc/CCDelegatedRendererLayerImplTest.cpp (working copy)
@@ -99,10 +99,10 @@
CCDelegatedRendererLayerImplTestSimple()
: CCDelegatedRendererLayerImplTest()
{
- scoped_ptr<CCLayerImpl> rootLayer = CCSolidColorLayerImpl::create(1).PassAs<CCLayerImpl>();
- scoped_ptr<CCLayerImpl> layerBefore = CCSolidColorLayerImpl::create(2).PassAs<CCLayerImpl>();
- scoped_ptr<CCLayerImpl> layerAfter = CCSolidColorLayerImpl::create(3).PassAs<CCLayerImpl>();
- scoped_ptr<CCDelegatedRendererLayerImpl> delegatedRendererLayer = CCDelegatedRendererLayerImpl::create(4);
+ OwnPtr<CCSolidColorLayerImpl> rootLayer = CCSolidColorLayerImpl::create(1);
+ OwnPtr<CCSolidColorLayerImpl> layerBefore = CCSolidColorLayerImpl::create(2);
+ OwnPtr<CCSolidColorLayerImpl> layerAfter = CCSolidColorLayerImpl::create(3);
+ OwnPtr<CCDelegatedRendererLayerImpl> delegatedRendererLayer = CCDelegatedRendererLayerImpl::create(4);
m_hostImpl->setViewportSize(IntSize(100, 100), IntSize(100, 100));
rootLayer->setBounds(IntSize(100, 100));
@@ -146,19 +146,19 @@
m_delegatedRendererLayerPtr = delegatedRendererLayer.get();
// Force the delegated RenderPasses to come before the RenderPass from layerAfter.
- layerAfter->addChild(delegatedRendererLayer.PassAs<CCLayerImpl>());
- rootLayer->addChild(layerAfter.Pass());
+ layerAfter->addChild(delegatedRendererLayer.release());
+ rootLayer->addChild(layerAfter.release());
// Get the RenderPass generated by layerBefore to come before the delegated RenderPasses.
- rootLayer->addChild(layerBefore.Pass());
+ rootLayer->addChild(layerBefore.release());
- m_hostImpl->setRootLayer(rootLayer.Pass());
+ m_hostImpl->setRootLayer(rootLayer.release());
}
protected:
- CCLayerImpl* m_rootLayerPtr;
- CCLayerImpl* m_layerBeforePtr;
- CCLayerImpl* m_layerAfterPtr;
+ CCSolidColorLayerImpl* m_rootLayerPtr;
+ CCSolidColorLayerImpl* m_layerBeforePtr;
+ CCSolidColorLayerImpl* m_layerAfterPtr;
CCDelegatedRendererLayerImpl* m_delegatedRendererLayerPtr;
};
@@ -382,8 +382,8 @@
CCDelegatedRendererLayerImplTestSharedData()
: CCDelegatedRendererLayerImplTest()
{
- scoped_ptr<CCLayerImpl> rootLayer = CCLayerImpl::create(1);
- scoped_ptr<CCDelegatedRendererLayerImpl> delegatedRendererLayer = CCDelegatedRendererLayerImpl::create(2);
+ OwnPtr<CCLayerImpl> rootLayer = CCLayerImpl::create(1);
+ OwnPtr<CCDelegatedRendererLayerImpl> delegatedRendererLayer = CCDelegatedRendererLayerImpl::create(2);
m_hostImpl->setViewportSize(IntSize(100, 100), IntSize(100, 100));
rootLayer->setBounds(IntSize(100, 100));
@@ -414,9 +414,9 @@
m_rootLayerPtr = rootLayer.get();
m_delegatedRendererLayerPtr = delegatedRendererLayer.get();
- rootLayer->addChild(delegatedRendererLayer.PassAs<CCLayerImpl>());
+ rootLayer->addChild(delegatedRendererLayer.release());
- m_hostImpl->setRootLayer(rootLayer.Pass());
+ m_hostImpl->setRootLayer(rootLayer.release());
}
protected:
« no previous file with comments | « cc/CCDelegatedRendererLayerImpl.h ('k') | cc/CCHeadsUpDisplayLayerImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698