Source/core/dom/DOMImplementation.idl - Issue 1108293002: Make DOMImplementation.hasFeature() always return true.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DOMImplementation.idl

Issue 1108293002: Make DOMImplementation.hasFeature() always return true. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: windows compilefix attempt Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/DOMImplementation.idl

diff --git a/Source/core/dom/DOMImplementation.idl b/Source/core/dom/DOMImplementation.idl

index 98764298beb26375612ccee6f7a654e39370df52..6ed29bbdf1c1754990916e666ea87612cd687e13 100644

--- a/Source/core/dom/DOMImplementation.idl

+++ b/Source/core/dom/DOMImplementation.idl

@@ -31,7 +31,6 @@

// FIXME: The title argument should not have a default value. crbug.com/335871

[NewObject] HTMLDocument createHTMLDocument(optional DOMString title = null);

- // FIXME: hasFeature should take no arguments and always return true. crbug.com/429536

- [ImplementedAs=hasFeatureForBindings, MeasureAs=DOMImplementationHasFeature]

- boolean hasFeature(DOMString feature, DOMString? version);

+ // useless; always returns true

+ boolean hasFeature();

};

« no previous file with comments | « Source/core/dom/DOMImplementation.cpp ('k') | Source/core/frame/UseCounter.cpp » ('j') | no next file with comments »